Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: minor updates to FastHrtime #33851

Closed
wants to merge 3 commits into from
Closed

src: minor updates to FastHrtime #33851

wants to merge 3 commits into from

Conversation

addaleax
Copy link
Member

  • Don’t use 12 as a magic number for the buffer size
  • Mark the object as weak (which is conceptually the right thing to do,
    even if there is little practical impact)
  • Keep a reference to the ArrayBuffer in question for memory tracking
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: minor updates to FastHrtime
cc82ea2 
- Don’t use 12 as a magic number for the buffer size
- Mark the object as weak (which is conceptually the right thing to do,
  even if there is little practical impact)
- Keep a reference to the `ArrayBuffer` in question for memory tracking
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 11, 2020
devsnek
devsnek approved these changes Jun 11, 2020
View reviewed changes
src/node_process_methods.cc Outdated Show resolved Hide resolved
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31861/

This was referenced Jun 18, 2020
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31935/

@addaleax
Copy link
Member Author

Landed in 52de4cb

@addaleax addaleax closed this Jun 19, 2020
addaleax added a commit that referenced this pull request Jun 19, 2020
@addaleax
src: minor updates to FastHrtime
52de4cb 
- Don’t use 12 as a magic number for the buffer size
- Mark the object as weak (which is conceptually the right thing to do,
  even if there is little practical impact)
- Keep a reference to the `ArrayBuffer` in question for memory tracking

PR-URL: #33851
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax deleted the fast-hrtime-adjustment branch June 19, 2020 15:35
@MylesBorins
Copy link
Contributor

This does not land cleanly on v14.x. @addaleax would it make sense to backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@addaleax @nodejs-github-bot @MylesBorins @jasnell @cjihrig @devnexen @devsnek