quic: always copy stateless reset token #33917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take ownership of the token value, since the memory for it is allocated anyway and the buffer size is just 16, i.e. copyable very cheaply. This makes valgrind stop complaining about a use-after-free error when running `sequential/test-quic-preferred-address-ipv6`.
nodejs-github-bot
added
the
c++
addaleax
added
the
quic
jasnell
approved these changes
Jun 17, 2020
|
CI: https://ci.nodejs.org/job/node-test-commit/39060/ test-quic-preferred-address-ipv6 failed on multiple systems in #33912, it's possible this fixes it, but I also think we need to skip ipv6 on some of the systems -- #33919 |
|
Not all of the quic tests will pass on all platforms yet |
|
@nodejs/quic ... fast track? |
lundibundi
approved these changes
Jun 17, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 17, 2020
Take ownership of the token value, since the memory for it is allocated anyway and the buffer size is just 16, i.e. copyable very cheaply. This makes valgrind stop complaining about a use-after-free error when running `sequential/test-quic-preferred-address-ipv6`. PR-URL: #33917 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in 133a97f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take ownership of the token value, since the memory for it is allocated
anyway and the buffer size is just 16, i.e. copyable very cheaply.
This makes valgrind stop complaining about a use-after-free error
when running
sequential/test-quic-preferred-address-ipv6.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes