Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: fix up node_quic_stream includes #33921

Closed
wants to merge 1 commit into from
Closed

quic: fix up node_quic_stream includes #33921

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 17, 2020

This commit removes the unused and includes, and adds
(for std::unique_ptr), and (for std::move).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 17, 2020
@danbev danbev added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31901/

jasnell
jasnell approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use quic: for the subsystem on these commits.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 17, 2020
@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

@nodejs/quic ... fast track?

@danbev
Copy link
Contributor Author

danbev commented Jun 17, 2020

Let's use quic: for the subsystem on these commits.

I'll use that in the future 👍

@jasnell jasnell changed the title src: fix up node_quic_stream includes quic: fix up node_quic_stream includes Jun 17, 2020
@danbev
quic: fix up node_quic_stream includes
c9b44a6 
This commit removes the unused <array> and <limits> includes, and adds
<memory> (for std::unique_ptr), and <utility> (for std::move).
jasnell pushed a commit that referenced this pull request Jun 19, 2020
@danbev @jasnell
quic: fix up node_quic_stream includes
1bd88a3 
This commit removes the unused <array> and <limits> includes, and adds
<memory> (for std::unique_ptr), and <utility> (for std::move).

PR-URL: #33921
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

Landed in 1bd88a3

@jasnell jasnell closed this Jun 19, 2020
@jasnell jasnell added the experimental Issues and PRs related to experimental features. label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danbev @nodejs-github-bot @jasnell @codebytere