quic: return 0 from SSL_CTX_sess_set_new_cb callback #33931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback passed to `SSL_CTX_sess_set_new_cb()` should return 1 if it takes ownership (i.e. holds a reference that is later freed through `SSL_SESSION_free()`) of the passed session, and 0 otherwise. Since we don’t take ownership of the session and instead only save a serialized version of it, return 0 instead of 1. This closes a memory leak reported when running `sequential/test-quic-preferred-address-ipv6`.
addaleax
added
the
quic
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Jun 17, 2020
danbev
approved these changes
Jun 18, 2020
tniessen
approved these changes
Jun 18, 2020
jasnell
added
author ready
This was referenced Jun 20, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 22, 2020
The callback passed to `SSL_CTX_sess_set_new_cb()` should return 1 if it takes ownership (i.e. holds a reference that is later freed through `SSL_SESSION_free()`) of the passed session, and 0 otherwise. Since we don’t take ownership of the session and instead only save a serialized version of it, return 0 instead of 1. This closes a memory leak reported when running `sequential/test-quic-preferred-address-ipv6`. PR-URL: #33931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 0e7c8bd |
This was referenced Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback passed to
SSL_CTX_sess_set_new_cb()should return 1if it takes ownership (i.e. holds a reference that is later freed
through
SSL_SESSION_free()) of the passed session, and 0otherwise.
Since we don’t take ownership of the session and instead only save
a serialized version of it, return 0 instead of 1. This closes
a memory leak reported when running
sequential/test-quic-preferred-address-ipv6.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes