Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.4.0 #34205

Merged
merged 1 commit into from
Jul 11, 2020
Merged

tools: update ESLint to 7.4.0 #34205

merged 1 commit into from
Jul 11, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 4, 2020

Update ESLint to 7.4.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 4, 2020
Trott
Trott approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 11, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32283/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2020
@cjihrig
tools: update ESLint to 7.4.0
b0d4eb3 
Update ESLint to 7.4.0

PR-URL: nodejs#34205
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit b0d4eb3 into nodejs:master Jul 11, 2020
@cjihrig cjihrig deleted the eslint branch July 11, 2020 19:52
@MylesBorins
Copy link
Member

this does not land cleanly on v14.x. Could someone backport or update on the v14.x branch

@Trott
Copy link
Member

Trott commented Jul 15, 2020

this does not land cleanly on v14.x. Could someone backport or update on the v14.x branch

@MylesBorins Cherry-pick 076e4ed first and then this PR/commit (b0d4eb3) will cherry-pick cleanly to v14.x-staging.

@targos targos added dont-land-on-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cjihrig @nodejs-github-bot @MylesBorins @Trott @addaleax @BridgeAR @targos