Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve wording in deprecations.md #34860

Closed
wants to merge 0 commits into from
Closed

doc: improve wording in deprecations.md #34860

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 21, 2020

  • utilize -> use
  • may -> can/might as appropriate
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Aug 21, 2020
Trott added a commit to Trott/io.js that referenced this pull request Aug 23, 2020
@Trott
doc: improve wording in deprecations.md
9c55970 
* utilize -> use
* may -> can/might as appropriate

PR-URL: nodejs#34860
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 23, 2020

Landed in 9c55970

@Trott Trott closed this Aug 23, 2020
@Trott Trott reopened this Aug 23, 2020
@Trott Trott closed this Aug 23, 2020
@Trott Trott deleted the dep-use-may branch August 23, 2020 11:06
BethGriggs pushed a commit that referenced this pull request Aug 24, 2020
@Trott @BethGriggs
doc: improve wording in deprecations.md
f2c2f42 
* utilize -> use
* may -> can/might as appropriate

PR-URL: #34860
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@trivikr trivikr trivikr approved these changes

@MrHeer MrHeer MrHeer approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Trott @jasnell @lpinca @targos @trivikr @MrHeer @nodejs-github-bot