Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix value check for writeUInt{B,L}E #3500

Closed
wants to merge 1 commit into from
Closed

buffer: fix value check for writeUInt{B,L}E #3500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/buffer.js
View file
Open in desktop
Expand Up @@ -832,8 +832,10 @@ Buffer.prototype.writeUIntLE = function(value, offset, byteLength, noAssert) {
value = +value;
offset = offset >>> 0;
byteLength = byteLength >>> 0;
if (!noAssert)
checkInt(this, value, offset, byteLength, Math.pow(2, 8 * byteLength), 0);
if (!noAssert) {
const maxBytes = Math.pow(2, 8 * byteLength) - 1;
checkInt(this, value, offset, byteLength, maxBytes, 0);
}

var mul = 1;
var i = 0;
Expand All @@ -849,8 +851,10 @@ Buffer.prototype.writeUIntBE = function(value, offset, byteLength, noAssert) {
value = +value;
offset = offset >>> 0;
byteLength = byteLength >>> 0;
if (!noAssert)
checkInt(this, value, offset, byteLength, Math.pow(2, 8 * byteLength), 0);
if (!noAssert) {
const maxBytes = Math.pow(2, 8 * byteLength) - 1;
checkInt(this, value, offset, byteLength, maxBytes, 0);
}

var i = byteLength - 1;
var mul = 1;
Expand Down
19 changes: 19 additions & 0 deletions test/parallel/test-writeuint.js
View file
Open in desktop
Expand Up @@ -122,6 +122,25 @@ function test32(clazz) {
}


function testUint(clazz) {
const data = new clazz(8);
var val = 1;

// Test 0 to 5 bytes.
for (var i = 0; i <= 5; i++) {
const errmsg = `byteLength: ${i}`;
ASSERT.throws(function() {
data.writeUIntBE(val, 0, i);
}, /value is out of bounds/, errmsg);
ASSERT.throws(function() {
data.writeUIntLE(val, 0, i);
}, /value is out of bounds/, errmsg);
val *= 0x100;
}
}


test8(Buffer);
test16(Buffer);
test32(Buffer);
testUint(Buffer);