stream: improve Writable.destroy performance #35067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid nextTick if there are no pending callbacks.
|
@nodejs/streams |
ronag
added
request-ci
ronag
changed the title
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Sep 5, 2020
ronag
force-pushed
the
writable-destroy-perf
branch
from
7588c63
to
ab7b73d
Compare
lpinca
approved these changes
Sep 5, 2020
github-actions
bot
removed
the
request-ci
rickyes
approved these changes
Sep 6, 2020
ronag
added
commit-queue
github-actions
bot
removed
the
request-ci
ronag
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/35067 ✔ Done loading data for nodejs/node/pull/35067 ----------------------------------- PR info ------------------------------------ Title stream: improve Writable.destroy performance (#35067) Author Robert Nagy (@ronag) Branch ronag:writable-destroy-perf -> nodejs:master Labels author ready, stream Commits 4 - stream: improbe Writable.destroy performance - fixup - fixup - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/35067 Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Ricky Zhou <0x19951125@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35067 Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Ricky Zhou <0x19951125@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ⚠ - fixup ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-09-07T09:00:43Z: https://ci.nodejs.org/job/node-test-pull-request/33086/ - Querying data for job/node-test-pull-request/33086/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sat, 05 Sep 2020 11:51:48 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35067#pullrequestreview-483051355 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35067#pullrequestreview-483067062 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35067#pullrequestreview-483072059 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35067#pullrequestreview-483143528 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
addaleax
approved these changes
Sep 7, 2020
addaleax
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/35067 ✔ Done loading data for nodejs/node/pull/35067 ----------------------------------- PR info ------------------------------------ Title stream: improve Writable.destroy performance (#35067) Author Robert Nagy (@ronag) Branch ronag:writable-destroy-perf -> nodejs:master Labels author ready, stream Commits 4 - stream: improbe Writable.destroy performance - fixup - fixup - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/35067 Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Ricky Zhou <0x19951125@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35067 Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Ricky Zhou <0x19951125@gmail.com> -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-09-07T14:21:04Z: https://ci.nodejs.org/job/node-test-pull-request/33086/ - Querying data for job/node-test-pull-request/33086/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sat, 05 Sep 2020 11:51:48 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35067#pullrequestreview-483051355 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/35067#pullrequestreview-483593618 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35067#pullrequestreview-483072059 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35067#pullrequestreview-483143528 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
|
@nodejs/build a little trouble landing with the GH action? Something you want to take a look at or should I just land this manually? |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 7, 2020
Avoid nextTick if there are no pending callbacks. PR-URL: nodejs#35067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
|
Landed in e0d3b75 |
|
@ronag |
|
Sorry if I stomped all over the "land manually? change edit permissions? something else?" conversation by landing this. Wasn't my intention. I figured @ronag probably would prefer a resolution (landing) over some back-and-forth about this, but maybe I'm wrong. |
|
@Trott imo it should always be 100% ok to land over this particular X, just trying to figure out the forensics on the implication that it was unavoidable. |
|
this doesn't land cleanly on |
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Avoid nextTick if there are no pending callbacks. PR-URL: nodejs#35067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
targos
added
dont-land-on-v14.x
and removed
backport-requested-v14.x
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid nextTick if there are no pending callbacks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes