meta: update my collab entry #35160
Merged
meta: update my collab entry #35160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Sep 12, 2020
mmarchini
approved these changes
Sep 12, 2020
|
+1 to fast track |
devsnek
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/35160 ✔ Done loading data for nodejs/node/pull/35160 ----------------------------------- PR info ------------------------------------ Title meta: update my collab entry (#35160) Author devsnek (@devsnek) Branch devsnek:devsnek-patch-1 -> nodejs:master Labels doc, fast-track Commits 1 - meta: update my collab entry Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/35160 Reviewed-By: Colin Ihrig Reviewed-By: Mary Marchini ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35160 Reviewed-By: Colin Ihrig Reviewed-By: Mary Marchini -------------------------------------------------------------------------------- ✖ GitHub CI is still running ℹ Doc-only changes ℹ This PR was created on Sat, 12 Sep 2020 00:01:33 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/35160#pullrequestreview-487180831 ✔ - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/35160#pullrequestreview-487181981 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
|
Heh, need to check for pending on GH Actions as well :) |
14 tasks
Trott
approved these changes
Sep 12, 2020
Trott
force-pushed
the
devsnek-patch-1
branch
2 times, most recently
from
56b80c1
to
b3c6d28
Compare
|
Landed in b3c6d28 |
PR-URL: #35160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
PR-URL: #35160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35160 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes