Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve pummel/test-timers.js #35175

Merged
merged 1 commit into from Sep 15, 2020
Merged

test: improve pummel/test-timers.js #35175

merged 1 commit into from Sep 15, 2020

Commits on Sep 15, 2020

  1. test: improve pummel/test-timers.js 

    * use Date.now() instead of new Date() because only the timestamp is
  ever used, so we don't need the full Date object
* use separate start times recorded for the two different test cases
* improve assertion messages

PR-URL: nodejs#35175
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
    @Trott
    Trott committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    ae257ca View commit details
    Browse the repository at this point in the history