Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update crypto.createSecretKey accepted types #35246

Merged
merged 1 commit into from
Sep 22, 2020
Merged

doc: update crypto.createSecretKey accepted types #35246

merged 1 commit into from
Sep 22, 2020

Conversation

panva
Copy link
Member

@panva panva commented Sep 17, 2020 •
edited
Loading

This updates the crypto.createSecretKey accepted types.

cc @tniessen

const encoder = new TextEncoder()
crypto.createSecretKey(Buffer.from('foo'))
crypto.createSecretKey(encoder.encode('foo'))
Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 17, 2020
@panva @Trott
doc: update crypto.createSecretKey accepted types
fb88257 
PR-URL: nodejs#35246
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 22, 2020

Landed in fb88257

@Trott Trott merged commit fb88257 into nodejs:master Sep 22, 2020
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
@panva @MylesBorins
doc: update crypto.createSecretKey accepted types
2a4ae09 
PR-URL: #35246
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@panva @joesepi
doc: update crypto.createSecretKey accepted types
d816dca 
PR-URL: nodejs#35246
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@panva panva deleted the fix-create-secret-key branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@panva @Trott @jasnell @lpinca @tniessen @nodejs-github-bot