-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update wpt tests for encoding #35330
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Sep 24, 2020
Leko
approved these changes
Sep 27, 2020
Trott
approved these changes
Sep 27, 2020
32e81ec
to
0636458
Compare
Rebased to fix conflicts |
watilde
added a commit
that referenced
this pull request
Sep 28, 2020
Refs: web-platform-tests/wpt#25542 PR-URL: #35330 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in 6fc3b0d |
hey @watilde this doesn't land cleanly on v14.x, would you be able to backport? |
watilde
added a commit
to watilde/node
that referenced
this pull request
Sep 30, 2020
Refs: web-platform-tests/wpt#25542 PR-URL: nodejs#35330 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
4 tasks
@MylesBorins Yes, I just made it on #35422 :) |
Merged
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Refs: web-platform-tests/wpt#25542 PR-URL: #35330 Backport-PR-URL: #35422 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: web-platform-tests/wpt#25542 PR-URL: nodejs#35330 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: web-platform-tests/wpt#25542
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes