Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update wpt tests for encoding #35330

Closed
wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 24, 2020

Refs: web-platform-tests/wpt#25542

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Sep 24, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

Rebased to fix conflicts

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

watilde added a commit that referenced this pull request Sep 28, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

Landed in 6fc3b0d

@MylesBorins
Copy link
Contributor

hey @watilde this doesn't land cleanly on v14.x, would you be able to backport?

watilde added a commit to watilde/node that referenced this pull request Sep 30, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde
Copy link
Member Author

watilde commented Sep 30, 2020

@MylesBorins Yes, I just made it on #35422 :)

@danielleadams danielleadams mentioned this pull request Oct 6, 2020
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
Refs: web-platform-tests/wpt#25542

PR-URL: #35330
Backport-PR-URL: #35422
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Refs: web-platform-tests/wpt#25542

PR-URL: nodejs#35330
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants