Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: do not throw exception after creating FSReqCallback #35487

Closed
wants to merge 2 commits into from

Commits on Oct 3, 2020

  1. fs: do not throw exception after creating FSReqCallback

    Once an `FSReqCallback` instance is created, it is a GC root until
    the underlying fs operation has completed, meaning that it cannot
    be garbage collected.
    
    This is a problem when the underlying operation never starts
    because an exception is thrown before that happens, for example
    as part of parameter validation.
    
    Instead, move all potentially throwing code before the `FSReqCallback`
    creation.
    addaleax committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    8a58544 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Configuration menu
    Copy the full SHA
    4f5c989 View commit details
    Browse the repository at this point in the history