-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 7.0.2 #35667
deps: upgrade npm to 7.0.2 #35667
Conversation
25afc9f
to
eb73004
Compare
/cc @nodejs/node-gyp the windows failures look gyp related. |
It's pretty infuriating how little info we get from windows failures like this, it really needs local testing. My guess is it's related to nodejs/gyp-next#71 but who really knows! @targos @ryzokuken we might need your help on this. |
The error is
The only idea I have is that we do avoid renaming absolute paths: nodejs/gyp-next#74 I applied it here to run CI |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM if CI is green
@targos thank you for finding the fix and floating the patch here. Do you have a timeline on a new release of node-gyp & gyp-next? We can float this patch on npm in the mean time and cut a 7.0.2 that includes some other fixes as well |
also, should we be floating this change on the internal version of gyp as well? |
I'm waiting for a review on nodejs/gyp-next#75 to do the release. |
This partially reverts c87641a as node-gyp no longer puts shared objects in an inconsistent location.
7c0cf25
to
d803f4b
Compare
updated to 7.0.2 which floats the gyp patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed same node-gyp code as is about to go out in a new release
Landed in fbe33aa...089d654 |
Refs: https://github.com/npm/cli/blob/latest/CHANGELOG.md#702-2020-10-16 PR-URL: #35667 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
7.0.2 (2020-10-16)
DOCUMENTATION
9476734b7
#1967
add mention to workspaces prepare lifecycle
(@ruyadorno)
BUG FIXES
5cf71c689
#1971
owner rm at local pkg not work
(@ShangguanQuail)
DEPENDENCIES
722b7ae63
#1974
patch node-gyp
(@targos)
4ae825c01
#1976
patch node-gyp
(@MylesBorins)
181eabf13
@npmcli/arborist@1.0.3
prepare
lifecycle scripts6cc115409
init-package-json@2.0.1
dbf9d6d1f
libnpmpublish@3.0.2