Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test to fs/promises setImmediate #35852

Merged
merged 1 commit into from
Oct 31, 2020
Merged

test: add test to fs/promises setImmediate #35852

merged 1 commit into from
Oct 31, 2020

Conversation

tyankatsu0105
Copy link
Contributor

Added test pattern to setImmediate when ref's type is not boolean

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 28, 2020
@shisama shisama added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33913/

rickyes
rickyes approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33929/

@Trott Trott mentioned this pull request Oct 29, 2020
Closed
3 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33931/ ✅

@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2020
@tyankatsu0105 @Trott
test: add test to fs/promises setImmediate
5dd344a 
Add test pattern to setImmediate when ref's type is not boolean

PR-URL: nodejs#35852
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the coverage/test-timers-promisifiled branch from b08259a to 5dd344a Compare October 31, 2020 11:48
@Trott Trott merged commit 5dd344a into nodejs:master Oct 31, 2020
@Trott
Copy link
Member

Trott commented Oct 31, 2020

Landed in 5dd344a

@Trott
Copy link
Member

Trott commented Oct 31, 2020

Thanks for the contribution! 🎉

@tyankatsu0105 tyankatsu0105 deleted the coverage/test-timers-promisifiled branch October 31, 2020 14:59
targos pushed a commit that referenced this pull request Nov 3, 2020
@tyankatsu0105 @targos
test: add test to fs/promises setImmediate
66ad4be 
Add test pattern to setImmediate when ref's type is not boolean

PR-URL: #35852
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Leko Leko Leko approved these changes

@watilde watilde watilde approved these changes

@shisama shisama shisama approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@tyankatsu0105 @nodejs-github-bot @Trott @yosuke-furukawa @benjamingr @Leko @watilde @shisama @rickyes @MylesBorins