Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.0.12 #36153

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.0.12 #36153

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

7.0.12 (2020-11-17)

BUG FIXES

DEPENDENCIES

  • b74c05d88 @npmcli/run-script@1.8.0
    • fix windows command-line argument escaping

DOCUMENTATION

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Nov 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34447/

Trott
Trott approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@ruyadorno ruyadorno added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2020
trivikr
trivikr approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott pushed a commit that referenced this pull request Nov 20, 2020
@ruyadorno @Trott
deps: upgrade npm to 7.0.12
8d381c0 
PR-URL: #36153
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 20, 2020

Landed in 8d381c0

@Trott Trott closed this Nov 20, 2020
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@ruyadorno @codebytere
deps: upgrade npm to 7.0.12
c23ee37 
PR-URL: #36153
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ruyadorno @nodejs-github-bot @Trott @lpinca @cjihrig @gireeshpunathil @BridgeAR @trivikr @MylesBorins