Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: refactor MessagePort entanglement management #36345

Closed
wants to merge 1 commit into from
Closed

worker: refactor MessagePort entanglement management #36345

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Dec 1, 2020

This addresses the TODO left on my request in 9e446b3. :)

Refs: #36271

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
worker: refactor MessagePort entanglement management
6334542 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: nodejs#36271
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2020
@addaleax addaleax requested a review from jasnell December 1, 2020 20:20
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34656/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34666/

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34764/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34785/ ✅

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2020
@github-actions
Copy link
Contributor

Landed in e28f23f...88dfecc

@github-actions github-actions bot closed this Dec 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 13, 2020
@addaleax @nodejs-github-bot
worker: refactor MessagePort entanglement management
88dfecc 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: #36271

PR-URL: #36345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax deleted the messageport-entanglement branch December 13, 2020 14:29
targos pushed a commit that referenced this pull request Dec 21, 2020
@addaleax @targos
worker: refactor MessagePort entanglement management
56fe9ba 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: #36271

PR-URL: #36345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
@richardlau richardlau mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @nodejs-github-bot @jasnell @Trott @targos