domains: emit uncaughtException when appropriate #3638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * given test tests one of these potentially eroneous behaviors that are | ||
| * currently accepted as correct. | ||
| */ | ||
|
|
misterdjules
force-pushed
the
fix-issue-3607-v0-12
branch
3 times, most recently
from
5a8cc6b
to
7dd903f
Compare
|
@misterdjules ... just a quick note: we'll want to land this in |
|
@jasnell Sounds good. |
added 2 commits
November 4, 2015 12:49
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when no error handler is set on the domain within which an error is thrown and an `'uncaughtException'` event listener is set on the process. Fixes nodejs#3607.
Make the process abort if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. If the domain within which the error is thrown has no error handler, but a domain further down the domains stack has one, the process will not abort. Fixes nodejs#3653
misterdjules
force-pushed
the
fix-issue-3607-v0-12
branch
from
13bd31e
to
68ca2b1
Compare
|
@jbergstroem Thank you for running the tests on this. I think the correct link to the CI results is https://ci.nodejs.org/job/node-test-commit/1040/. Anyway, I needed to run tests again because since then I updated this PR with a new commit. CI running here: https://ci.nodejs.org/job/node-test-pull-request/677/. |
This was referenced Nov 13, 2015
|
Closing in favor of #3885. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix node exiting due to an exception being thrown rather than emitting
an
'uncaughtException'event on the process object when no errorhandler is set on the domain within which an error is thrown and an
'uncaughtException'event listener is set on the process.Fixes #3607.
/cc @nodejs/lts @nodejs/tsc @nodejs/collaborators