domains: emit uncaughtException when appropriate #3640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterdjules
force-pushed
the
fix-issue-3607-master
branch
from
6d1f73c
to
04b75ca
Compare
misterdjules
force-pushed
the
fix-issue-3607-master
branch
from
04b75ca
to
f5ffc5a
Compare
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when no error handler is set on the domain within which an error is thrown and an `'uncaughtException'` event listener is set on the process. Fixes nodejs#3607.
misterdjules
force-pushed
the
fix-issue-3607-master
branch
from
f5ffc5a
to
bb645c2
Compare
| @@ -0,0 +1,203 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Should this be test-domain-uncaught-exception.js? Seems more explicit.
There was a problem hiding this comment.
Good point, renamed in #3654.
|
Closing in favor of #3654. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix node exiting due to an exception being thrown rather than emitting
an
'uncaughtException'event on the process object when no errorhandler is set on the domain within which an error is thrown and an
'uncaughtException'event listener is set on the process.Fixes #3607.
/cc @nodejs/tsc @nodejs/collaborators.