Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add v15.4.0 link to CHANGELOG.md #36456

Closed
wants to merge 1 commit into from
Closed

doc: add v15.4.0 link to CHANGELOG.md #36456

wants to merge 1 commit into from

Conversation

danielleadams
Copy link
Member

@danielleadams danielleadams commented Dec 9, 2020 •
edited

Description

Adding a link to the CHANGELOG.md for the latest 15.x release.

Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 9, 2020
@danielleadams
Copy link
Member Author

Should this be merged into master or wait to cherry-pick this into the next 15.x release?

@Trott
Copy link
Member

Trott commented Dec 13, 2020

Should this be merged into master or wait to cherry-pick this into the next 15.x release?

I imagine this question is aimed at other @nodejs/releasers members? I'd assumed land on master but defer to the opinion of @nodejs/releasers members as I'm not sure if or how anything like that would affect the release process.

@MylesBorins
Copy link
Member

I think merge into master and cherry-pick to 15 makes the most sense. We want this fixed in both.

MylesBorins
MylesBorins approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Member

Landed in 04e5418

MylesBorins pushed a commit that referenced this pull request Dec 14, 2020
@danielleadams @MylesBorins
doc: add v15.4.0 link to CHANGELOG.md
04e5418 
PR-URL: #36456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
@danielleadams @targos
doc: add v15.4.0 link to CHANGELOG.md
25a2454 
PR-URL: #36456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
@danielleadams danielleadams deleted the add-v15.4.0-to-changelog branch March 4, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@codebytere codebytere codebytere approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@danielleadams @Trott @MylesBorins @fhinkel @lpinca @codebytere @richardlau @BethGriggs @targos @nodejs-github-bot