doc: add note about uncloneable objects #36534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Dec 15, 2020
jasnell
commented
Dec 15, 2020
jasnell
commented
Dec 15, 2020
benjamingr
approved these changes
Dec 16, 2020
lpinca
approved these changes
Dec 16, 2020
Trott
reviewed
Dec 16, 2020
Trott
reviewed
Dec 16, 2020
jasnell
force-pushed
the
add-note-about-uncloneable-objects
branch
from
35c274b
to
f30ceac
Compare
jasnell
added
the
author ready
|
This needs a rebase |
targos
removed
the
author ready
Trott
approved these changes
Dec 23, 2020
fhinkel
approved these changes
Dec 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
add-note-about-uncloneable-objects
branch
from
f30ceac
to
cc177d9
Compare
|
Landed in 6ab768e |
jasnell
added a commit
that referenced
this pull request
Dec 31, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36534 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36534 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes