Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unnecessary ToLocalChecked node_errors #36547

Closed
wants to merge 1 commit into from
Closed

src: remove unnecessary ToLocalChecked node_errors #36547

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 17, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34981/

@danbev
Copy link
Contributor Author

danbev commented Dec 22, 2020 •
edited
Loading

Re-run of failing node-test-commit-osx ✔️
Re-run of failing node-test-commit-smartos ✔️

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2020
danbev added a commit that referenced this pull request Dec 22, 2020
@danbev
src: remove unnecessary ToLocalChecked node_errors
fc8fcb0 
PR-URL: #36547
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Dec 22, 2020

Landed in fc8fcb0.

@danbev danbev closed this Dec 22, 2020
@danbev danbev deleted the node_errors_tolocalchecked branch December 22, 2020 08:35
targos pushed a commit that referenced this pull request Dec 22, 2020
@danbev @targos
src: remove unnecessary ToLocalChecked node_errors
d38a0ec 
PR-URL: #36547
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@danbev @targos
src: remove unnecessary ToLocalChecked node_errors
c308b06 
PR-URL: #36547
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danbev @nodejs-github-bot @Trott @cjihrig @gireeshpunathil