Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: revert incomingmessage autodestroy #36647

Closed
wants to merge 1 commit into from
Closed

http: revert incomingmessage autodestroy #36647

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Dec 27, 2020

This reverts commits:

Because of the breaking change in the order of emitting the close event in IncomingMessage described in #33035 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@dnlup
Revert "http: use autoDestroy: true in incoming message"
57f11ca 
This reverts commits:

* 55e83cb
* 6120028
* 70eaf55
* 5ae9690
* f20a88f
* a6bf74e
* 8154e47

Because of the breaking change in the order of emitting the `close`
event in `IncomingMessage` described in:
  nodejs#33035 (comment)
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v15.x labels Dec 27, 2020
@dnlup dnlup mentioned this pull request Dec 27, 2020
Closed
2 tasks
@ronag ronag requested a review from mcollina December 27, 2020 20:06
@ronag
Copy link
Member

ronag commented Dec 27, 2020

@nodejs/http

mcollina
mcollina approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devinivy devinivy mentioned this pull request Dec 28, 2020
Closed
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35111/

MylesBorins pushed a commit that referenced this pull request Jan 5, 2021
@dnlup @MylesBorins
Revert "http: use autoDestroy: true in incoming message"
c784f15 
This reverts commits:

* 55e83cb
* 6120028
* 70eaf55
* 5ae9690
* f20a88f
* a6bf74e
* 8154e47

Because of the breaking change in the order of emitting the `close`
event in `IncomingMessage` described in:
  #33035 (comment)

PR-URL: #36647
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

Landed in c784f15

@MylesBorins MylesBorins closed this Jan 5, 2021
@dnlup dnlup deleted the fix/revert_incoming_autodestroy branch January 5, 2021 16:23
@dnlup dnlup mentioned this pull request Jan 12, 2021
Closed
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
@targos targos mentioned this pull request Jun 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dnlup @ronag @nodejs-github-bot @MylesBorins @mcollina @Trott