Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, tools, win: update nasm detection #36689

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Dec 30, 2020

Keep the same output format with find_python.cmd

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 30, 2020
@himself65 himself65 marked this pull request as draft December 30, 2020 14:19
@himself65 himself65 marked this pull request as ready for review December 30, 2020 14:28
@himself65 himself65 force-pushed the 20201230-find_nasm.cmd branch 2 times, most recently from 827607a to 84fc21f Compare December 30, 2020 14:48
Logs the NASM path when it found.
tools/msvs/find_nasm.cmd Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants