Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rename n-api to node-api #37217

Merged
merged 1 commit into from
Feb 6, 2021
Merged

test: rename n-api to node-api #37217

merged 1 commit into from
Feb 6, 2021

Conversation

gabrielschulhof
Copy link
Contributor

This renames the macros used in the tests from NAPI_* to
NODE_API_*.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2021
@gabrielschulhof gabrielschulhof mentioned this pull request Feb 3, 2021
Closed
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Feb 3, 2021
mhdawson
mhdawson approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35966/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35972/

@Trott
test: rename n-api to node-api
4b7f23f 
This renames the macros used in the tests from `NAPI_*` to
`NODE_API_*`.

PR-URL: nodejs#37217
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Feb 6, 2021

Landed in 4b7f23f

@Trott Trott merged commit 4b7f23f into nodejs:master Feb 6, 2021
@gabrielschulhof gabrielschulhof deleted the rename-napi-test branch February 6, 2021 22:36
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@danielleadams
test: rename n-api to node-api
48a634e 
This renames the macros used in the tests from `NAPI_*` to
`NODE_API_*`.

PR-URL: #37217
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
@gabrielschulhof gabrielschulhof mentioned this pull request Mar 7, 2021
Closed
@danielleadams
Copy link
Member

@gabrielschulhof do you mind opening a 14.x backport PR? There are failing tests when these changes are pulled in.

This was referenced Jul 16, 2021
Closed
Closed
Closed
@toyobayashi toyobayashi mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

@marsonya marsonya marsonya approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gabrielschulhof @nodejs-github-bot @Trott @danielleadams @BethGriggs @mhdawson @marsonya @targos