Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update web platform tests #37467

Closed
wants to merge 3 commits into from
Closed

Fix and update web platform tests #37467

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 21, 2021

  • test: redownload wpt fixtures with correct encoding
  • test: update all Web Platform Tests

The fixtures were generated with a modified version of node-core-utils
containing these two PRs:

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 21, 2021
mhdawson
mhdawson approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36325/

@mhdawson
Copy link
Member

CI run - https://ci.nodejs.org/job/node-test-pull-request/36325/

@jasnell
Copy link
Member

jasnell commented Feb 23, 2021

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36339/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36422/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36448/

@targos
Copy link
Member Author

targos commented Mar 3, 2021

There are many unexpected failures with TextDecoder specific to Windows.
I don't know if it's something we should look into or if we can just skip these tests.

@jasnell wdyt?

Example:

17:56:18     ---- legacy-mb-schinese\gbk\gbk-decoder.any.js ----
17:56:18     [UNEXPECTED_FAILURE][FAIL] gbk pointer: 6432
17:56:18     assert_equals: expected 8364 but got 59244
17:56:18         at Test.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\wpt\encoding\legacy-mb-schinese\gbk\gbk-decoder.any.js:26:9)
17:56:18         at Test.step (C:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\wpt\resources\testharness.js:2092:25)
17:56:18         at test (C:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\wpt\resources\testharness.js:566:30)
17:56:18         at C:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\wpt\encoding\legacy-mb-schinese\gbk\gbk-decoder.any.js:20:5
17:56:18         at Script.runInThisContext (node:vm:131:12)
17:56:18     Command: C:\workspace\node-test-binary-windows-js-suites\node\Release\node.exe  C:\workspace\node-test-binary-windows-js-suites\node\test\wpt\test-encoding.js legacy-mb-schinese\gbk\gbk-decoder.any.js

@jasnell
Copy link
Member

jasnell commented Mar 3, 2021

Let's skip those for now but open a tracking issue to investigate. I'm not sure why those would fail on windows of the top of my head

@targos
Copy link
Member Author

targos commented Mar 3, 2021

Actually I think I know why they fail only on Windows...
I already skipped them in the status file. It's probably not taken into account on Windows because of the different path separator.

image

@targos
Copy link
Member Author

targos commented Mar 3, 2021

Should be fixed with e5d071e

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36460/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36462/

targos added a commit that referenced this pull request Mar 3, 2021
@targos
test: redownload wpt fixtures with correct encoding
5303d4e 
PR-URL: #37467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Mar 3, 2021
@targos
test: update all Web Platform Tests
0c11f2e 
PR-URL: #37467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos
Copy link
Member Author

targos commented Mar 3, 2021

Landed in 26288ff...0c11f2e

@targos targos closed this Mar 3, 2021
@targos targos deleted the update-wpt branch March 3, 2021 21:17
@MattiasBuelens MattiasBuelens mentioned this pull request Mar 10, 2021
Closed
4 tasks
@targos targos mentioned this pull request Mar 15, 2021
Closed
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@targos @danielleadams
test: redownload wpt fixtures with correct encoding
c09bd77 
PR-URL: #37467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@targos @danielleadams
test: update all Web Platform Tests
a44daff 
PR-URL: #37467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@targos @nodejs-github-bot @mhdawson @jasnell @Trott @richardlau