Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls #37533

Merged
merged 1 commit into from
Mar 1, 2021
Merged

test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls #37533

merged 1 commit into from
Mar 1, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 27, 2021

The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36393/

@Trott
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
2748b0a 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: nodejs#30845

PR-URL: nodejs#37533
Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 1, 2021

Landed in 2748b0a

@Trott Trott merged commit 2748b0a into nodejs:master Mar 1, 2021
@Trott Trott deleted the remove-from-status branch March 1, 2021 20:20
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
@Trott @lpinca
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
f1e4c34 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: nodejs#30845

PR-URL: nodejs#37533
Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 2, 2021
@Trott @targos
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
9696cf7 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls
097f638 
The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

PR-URL: #37533
Fixes: #30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-multistream-destroy-on-read-tls
5 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig