Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use bundled npm in update scripts #37613

Closed

Commits on Mar 10, 2021

  1. tools: use bundled npm in update scripts

    The scripts `./tools/update-babel-eslint.sh` and
    `./tools/update-eslint.sh` are relying on the version of `npm` found in
    the local-defined `$PATH` env.
    
    This changeset proposes to modify these scripts to run the version of
    npm bundled in the current branch (found at `./deps/npm`) - in order to:
    
    a) Standardize the version of npm that should be use to install these
    deps, avoids the pitfall of having an inadverted user run these
    scripts with an unsupported/incompatible npm version.
    b) Given that npm7 has a different install algorithm than npm6 that
    takes into account and install peer dependencies, it might be a safer
    choice to ensure what version of npm should be use during this
    transitional period in which users might still have npm6 by default in
    their local system.
    c) Avoids the possible extra churn of having different resulting files
    being shuffled around between installs due to usage of a disparate
    version of the npm cli.
    ruyadorno committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    d5da1a2 View commit details
    Browse the repository at this point in the history