Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clear obsolete FLAKY entries #37631

Merged
merged 2 commits into from Mar 8, 2021
Merged

test: clear obsolete FLAKY entries #37631

merged 2 commits into from Mar 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 6, 2021

test-stream-pipeline-http2 and test-http2-pipe haven't failed for a long time.

Closes: #20750

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36514/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36525/

@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

@nodejs/testing This could use another review.

@Trott
test: clear FLAKY designation for test-http2-pipe
cd4b095 
It hasn't failed in a long time.

Refs: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@Trott
test: clear flaky designation for test-stream-pipeline-http2
f108778 
It hasn't failed for a long time.

Closes: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@Trott Trott merged commit f108778 into nodejs:master Mar 8, 2021
@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

Landed in 8ab6a6c...f108778

@Trott Trott deleted the rm-obsolete-flaky branch March 8, 2021 14:25
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Trott @danielleadams
test: clear FLAKY designation for test-http2-pipe
381fb98 
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Trott @danielleadams
test: clear flaky designation for test-stream-pipeline-http2
d5ff50d 
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: clear FLAKY designation for test-http2-pipe
ed30e52 
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: clear flaky designation for test-stream-pipeline-http2
102d12f 
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-http2-* on Windows
4 participants
@Trott @nodejs-github-bot @ruyadorno @targos