perf: add toJSON to performance class #37771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
This should include a test |
targos
reviewed
Mar 16, 2021
Yes will be adding it. |
yashLadha
force-pushed
the
add_to_json_performance
branch
2 times, most recently
from
551aa74
to
5647f64
Compare
|
Added test @jasnell |
yashLadha
force-pushed
the
add_to_json_performance
branch
4 times, most recently
from
a439e79
to
93ca72e
Compare
himself65
reviewed
Mar 19, 2021
targos
reviewed
Mar 20, 2021
yashLadha
force-pushed
the
add_to_json_performance
branch
2 times, most recently
from
27a066c
to
73e6da2
Compare
targos
reviewed
Mar 23, 2021
targos
reviewed
Mar 23, 2021
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-method Fixes: nodejs#37623
yashLadha
force-pushed
the
add_to_json_performance
branch
from
73e6da2
to
6c99cc7
Compare
jasnell
approved these changes
Apr 28, 2021
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 93f0b4d |
jasnell
pushed a commit
that referenced
this pull request
Apr 30, 2021
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-method Fixes: #37623 PR-URL: #37771 Fixes: #37623 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2021
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-method Fixes: #37623 PR-URL: #37771 Fixes: #37623 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method
Fixes: #37623