Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: change wording in lib/domain.js comment to be more inclusive #37933

Closed
wants to merge 1 commit into from
Closed

lib: change wording in lib/domain.js comment to be more inclusive #37933

wants to merge 1 commit into from

Conversation

marsonya
Copy link
Member

Change the wording to make the language more Inclusive.

@nodejs-github-bot nodejs-github-bot added domain Issues and PRs related to the domain subsystem. needs-ci PRs that need a full CI run. labels Mar 26, 2021
merceyz
merceyz reviewed Mar 26, 2021
View reviewed changes
lib/domain.js Outdated Show resolved Hide resolved
@marsonya
lib: change wording in lib/domain.js comment
5685117 
Change the wording to make the language more Inclusive.
@marsonya marsonya added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 29, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37078/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37097/

@jasnell
Copy link
Member

jasnell commented Apr 1, 2021

Landed in e0eb515

@jasnell jasnell closed this Apr 1, 2021
jasnell pushed a commit that referenced this pull request Apr 1, 2021
@marsonya @jasnell
lib: change wording in lib/domain.js comment
e0eb515 
Change the wording to make the language more Inclusive.

PR-URL: #37933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@marsonya @MylesBorins
lib: change wording in lib/domain.js comment
8525231 
Change the wording to make the language more Inclusive.

PR-URL: #37933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
lib: change wording in lib/domain.js comment
1d82693 
Change the wording to make the language more Inclusive.

PR-URL: #37933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. domain Issues and PRs related to the domain subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@marsonya @nodejs-github-bot @jasnell @Trott @addaleax @cjihrig @merceyz @BethGriggs @BridgeAR @RaisinTen