util: remove unreachable inspect code #37941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
dnlup
approved these changes
Mar 27, 2021
cjihrig
approved these changes
Mar 27, 2021
jasnell
approved these changes
Mar 27, 2021
Convert invariant from if statement to an assertion. The condition is believed to be impossible to trigger. PR-URL: nodejs#37941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
force-pushed
the
remove-unreachable
branch
from
011792d
to
45cdc13
Compare
|
Landed in 45cdc13 |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 29, 2021
Convert invariant from if statement to an assertion. The condition is believed to be impossible to trigger. PR-URL: #37941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 30, 2021
Convert invariant from if statement to an assertion. The condition is believed to be impossible to trigger. PR-URL: #37941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Convert invariant from if statement to an assertion. The condition is believed to be impossible to trigger. PR-URL: #37941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.