Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove extra semi after member fn #38686

Closed
wants to merge 1 commit into from

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented May 14, 2021

Added in #34186 and #38172 - causes build failures in Electron.

In file included from ../../third_party/electron_node/src/inspector_agent.cc:18:
../../third_party/electron_node/src/timer_wrap.h:35:23: error: extra ';' after member function definition [-Werror,-Wextra-semi]
  SET_NO_MEMORY_INFO();
                      ^
1 error generated.
[740/12750] CXX obj/cc/cc/layer_tree_host_impl.o
In file included from ../../third_party/electron_node/src/cares_wrap.cc:25:
../../third_party/electron_node/src/cares_wrap.h:144:37: error: extra ';' after member function definition [-Werror,-Wextra-semi]
  SET_MEMORY_INFO_NAME(NodeAresTask);
                                    ^
../../third_party/electron_node/src/cares_wrap.h:145:30: error: extra ';' after member function definition [-Werror,-Wextra-semi]
  SET_SELF_SIZE(NodeAresTask);
                             ^
2 errors generated.
@codebytere codebytere force-pushed the remove-extra-semi branch from af935fe to d8e9367 May 14, 2021
codebytere added a commit to electron/electron that referenced this issue May 14, 2021
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 14, 2021

Trott
Trott approved these changes May 16, 2021
codebytere added a commit that referenced this issue May 16, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere
Copy link
Member Author

@codebytere codebytere commented May 16, 2021

Landed in 82eddca

@codebytere codebytere closed this May 16, 2021
@codebytere codebytere deleted the remove-extra-semi branch May 16, 2021
targos added a commit that referenced this issue May 17, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere added a commit to electron/electron that referenced this issue May 18, 2021
codebytere added a commit to electron/electron that referenced this issue May 20, 2021
targos added a commit that referenced this issue May 30, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere added a commit to electron/electron that referenced this issue May 31, 2021
codebytere added a commit to electron/electron that referenced this issue May 31, 2021
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere added a commit to electron/electron that referenced this issue Jun 8, 2021
codebytere added a commit to electron/electron that referenced this issue Jun 9, 2021
codebytere added a commit to electron/electron that referenced this issue Jun 10, 2021
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #38686
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants