lib: add 'pid' prefix in `internal/util` #3878

JungMinu · 2015-11-17T08:59:50Z

This PR improves prefix in util that we've agreed on #3833
(separate PR for javascript in lib, and the original PR will be updated to move the printing function to C++ in src directly)

cjihrig · 2015-11-17T16:28:51Z

LGTM

evanlucas · 2015-11-17T16:29:39Z

won't this break some tests?

cjihrig · 2015-11-17T16:31:55Z

I would imagine for any tests checking for the old string. @JungMinu did you run the tests locally with your changes?

silverwind · 2015-11-17T19:43:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/768/

jasnell · 2015-11-17T19:53:51Z

LGTM if CI is green

Update: ... which, it's not ... sadly. @JungMinu , can you please take a look at the failing tests and update those here as well. Thank you!

evanlucas · 2015-11-17T19:55:33Z

Yea, test-deprecation-flags.js is failing

jasnell · 2015-11-18T04:47:44Z

@JungMinu ... I'll take a look in the morning. Could you post the failure that you're seeing, however?

martfors · 2015-11-18T07:17:19Z

Looking at the test message I'm guessing this is because you haven't updated the test to use your new prefix instead of the hardcoded one when comparing the two warnings.

JungMinu · 2015-11-18T08:53:33Z

@jasnell I found the solution, Thanks :)

targos · 2015-11-18T09:12:14Z

test/sequential/test-deprecation-flags.js

@@ -3,6 +3,7 @@ var common = require('../common');
 var assert = require('assert');
 var execFile = require('child_process').execFile;
 var depmod = require.resolve('../fixtures/deprecated.js');
+const prefix = `(${process.release.name}:${process.pid + 1}) `;


are we sure that the child process' pid will always be current+1 ?

@targos would you recommend alternative to fix this? :)

I would use a RegExp to match stderr

Agree, something like assert(/util\.debug is deprecated/.test(stderr)) could suffice, but you could also use the RegExp constructor to match the whole line.

@targos @silverwind Yup, I will update soon, Thanks :)

JungMinu · 2015-11-19T07:26:25Z

@jasnell @silverwind @cjihrig Thanks, finished with RegExp:)

jasnell · 2015-11-19T17:41:49Z

New CI Run: https://ci.nodejs.org/job/node-test-pull-request/784/

cjihrig · 2015-11-19T17:59:33Z

test/sequential/test-deprecation-flags.js

-  assert.equal(stderr, '(node) util.debug is deprecated. Use console.error ' +
-                       'instead.\nDEBUG: This is deprecated\n');
+  const stderrResult = stderr.replace(/ *\([^)]*\) */g, '');
+  assert.equal(stderrResult, 'util.debug is deprecated. Use console.error ' +


Sorry, just looking at this again. Couldn't you just assert(/util\.debug is deprecated.../.test(stderr));

JungMinu · 2015-11-19T20:50:30Z

@cjihrig Sure, updated :)

cjihrig · 2015-11-19T20:56:53Z

test/sequential/test-deprecation-flags.js

@@ -16,8 +16,7 @@ execFile(node, normal, function(er, stdout, stderr) {
  console.error('normal: show deprecation warning');
  assert.equal(er, null);
  assert.equal(stdout, '');
-  assert.equal(stderr, '(node) util.debug is deprecated. Use console.error ' +
-                       'instead.\nDEBUG: This is deprecated\n');
+  assert(/util\.debug is deprecated.../.test(stderr));


Heh. I put ... in my original comment to avoid typing out the entire message. Sorry for the mix up.

Funny, this should actually still work, since . matches a single character. I don't think it's necessary to try to match the entire deprecation message verbatim. Drop the ... and this LGTM. Sorry again.

This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) lib: add 'pid' prefix in `internal/util`

JungMinu · 2015-11-19T21:05:49Z

@cjihrig No problem, finished :)

silverwind · 2015-11-20T11:56:22Z

LGTM pending CI:

https://ci.nodejs.org/job/node-test-pull-request/795/

jasnell · 2015-11-20T15:50:13Z

Seeing one possibly flaky test error in CI (see https://ci.nodejs.org/job/node-test-commit-linux/1271/nodes=fedora21/console). Assuming that's an unrelated error, LGTM

targos · 2015-11-20T15:56:38Z

LGTM

cjihrig · 2015-11-20T15:57:41Z

LGTM (still)

jasnell · 2015-11-20T17:21:30Z

will get this landed!

This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) PR-URL: #3878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2015-11-20T17:26:55Z

Landed in d01eb68

jasnell · 2015-11-20T17:27:33Z

@JungMinu ... I know that #3833 is still pending. Hopefully we can close on that one soon

JungMinu · 2015-11-20T17:32:02Z

@jasnell Yes, I will finish that PR tomorrow :)

jasnell · 2015-11-20T17:34:00Z

thank you @JungMinu !

rvagg · 2015-12-05T04:47:15Z

I believe this should be semver-major like the other changes to error messages. Tagging it as such will ensure it won't slip in to v5.x (like it just did while I was working through the list).

Please speak up if you disagree or if you think I'm reading this wrong.

jasnell · 2015-12-05T04:47:55Z

Works for me
On Dec 4, 2015 8:47 PM, "Rod Vagg" notifications@github.com wrote:

I believe this should be semver-major like the other changes to error
messages. Tagging it as such will ensure it won't slip in to v5.x (like it
just did while I was working through the list).

Please speak up if you disagree or if you think I'm reading this wrong.

—
Reply to this email directly or view it on GitHub
#3878 (comment).

JungMinu · 2015-12-05T04:52:12Z

@rvagg Sounds good to me :)

mscdex added the util Issues and PRs related to the built-in util module. label Nov 17, 2015

targos reviewed Nov 18, 2015
View reviewed changes

cjihrig reviewed Nov 19, 2015
View reviewed changes

lib: add 'pid' prefix in internal/util

fe93a28

This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) lib: add 'pid' prefix in `internal/util`

jasnell closed this Nov 20, 2015

jasnell mentioned this pull request Nov 20, 2015

lib,src: Ensure '(node:pid)' prefix for stdout logging #3833

Closed

Fishrock123 mentioned this pull request Nov 26, 2015

deps: upgrade npm to 3.5.0 #4032

Closed

rvagg added the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 5, 2015

Fishrock123 mentioned this pull request Dec 15, 2015

v5.3.0 Release Proposal (Stable) #4281

Closed

jasnell mentioned this pull request Mar 17, 2016

Planning for v6 #5766

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: add 'pid' prefix in `internal/util` #3878

lib: add 'pid' prefix in `internal/util` #3878

JungMinu commented Nov 17, 2015

cjihrig commented Nov 17, 2015

evanlucas commented Nov 17, 2015

cjihrig commented Nov 17, 2015

silverwind commented Nov 17, 2015

jasnell commented Nov 17, 2015

evanlucas commented Nov 17, 2015

jasnell commented Nov 18, 2015

martfors commented Nov 18, 2015

JungMinu commented Nov 18, 2015

targos Nov 18, 2015

JungMinu Nov 18, 2015

targos Nov 18, 2015

silverwind Nov 18, 2015

JungMinu Nov 18, 2015

JungMinu commented Nov 19, 2015

jasnell commented Nov 19, 2015

cjihrig Nov 19, 2015

JungMinu commented Nov 19, 2015

cjihrig Nov 19, 2015

JungMinu commented Nov 19, 2015

silverwind commented Nov 20, 2015

jasnell commented Nov 20, 2015

targos commented Nov 20, 2015

cjihrig commented Nov 20, 2015

jasnell commented Nov 20, 2015

jasnell commented Nov 20, 2015

jasnell commented Nov 20, 2015

JungMinu commented Nov 20, 2015

jasnell commented Nov 20, 2015

rvagg commented Dec 5, 2015

jasnell commented Dec 5, 2015

JungMinu commented Dec 5, 2015

lib: add 'pid' prefix in internal/util #3878

lib: add 'pid' prefix in internal/util #3878

Conversation

JungMinu commented Nov 17, 2015

cjihrig commented Nov 17, 2015

evanlucas commented Nov 17, 2015

cjihrig commented Nov 17, 2015

silverwind commented Nov 17, 2015

jasnell commented Nov 17, 2015

evanlucas commented Nov 17, 2015

jasnell commented Nov 18, 2015

martfors commented Nov 18, 2015

JungMinu commented Nov 18, 2015

targos Nov 18, 2015

Choose a reason for hiding this comment

JungMinu Nov 18, 2015

Choose a reason for hiding this comment

targos Nov 18, 2015

Choose a reason for hiding this comment

silverwind Nov 18, 2015

Choose a reason for hiding this comment

JungMinu Nov 18, 2015

Choose a reason for hiding this comment

JungMinu commented Nov 19, 2015

jasnell commented Nov 19, 2015

cjihrig Nov 19, 2015

Choose a reason for hiding this comment

JungMinu commented Nov 19, 2015

cjihrig Nov 19, 2015

Choose a reason for hiding this comment

JungMinu commented Nov 19, 2015

silverwind commented Nov 20, 2015

jasnell commented Nov 20, 2015

targos commented Nov 20, 2015

cjihrig commented Nov 20, 2015

jasnell commented Nov 20, 2015

jasnell commented Nov 20, 2015

jasnell commented Nov 20, 2015

JungMinu commented Nov 20, 2015

jasnell commented Nov 20, 2015

rvagg commented Dec 5, 2015

jasnell commented Dec 5, 2015

JungMinu commented Dec 5, 2015

lib: add 'pid' prefix in `internal/util` #3878

lib: add 'pid' prefix in `internal/util` #3878