New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: standardize on "Long Term Support" #38841

Merged

Trott merged 2 commits into nodejs:master from Trott:lts

May 31, 2021

Member

Trott commented May 29, 2021

I'll add a lint rule to the Node.js remark lint preset.

github-actions bot added the doc label

DerekNonGeneric approved these changes

View reviewed changes

bl-ue approved these changes

View reviewed changes

targos approved these changes

View reviewed changes

Contributor

phershbe commented May 29, 2021

Yeah sounds good, thank you for making the changes. I added another comment to the discussion that we having before. I'm listing the link for anybody who wants to understand the logic behind the changes: #38839

Trott added a commit to Trott/remark-preset-lint-node that referenced this pull request


          feat: add linting for "Long Term Support"

5d11629

Refs: nodejs/node#38841
Refs: nodejs/node#38839

Trott mentioned this pull request

feat: add linting for "Long Term Support" nodejs/remark-preset-lint-node#185

Merged

lpinca approved these changes

View reviewed changes

RaisinTen approved these changes

View reviewed changes

cjihrig approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

jasnell added the author ready label

mhdawson approved these changes

View reviewed changes

Member

mhdawson left a comment

LGTM

Trott force-pushed the lts branch from 6727b7a to 01f85a2 Compare

May 31, 2021 18:41

Trott added 2 commits

May 31, 2021 11:42


          doc: use "Long Term Support" in technical values doc

0ba7da6

Use "Long Term Support" rather than "long term support".

Refs: nodejs#38839 (comment)

PR-URL: nodejs#38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>


          doc: use "Long Term Support" in collaborator guide

58bd046

Use "Long Term Support" rather than "Long-term support".

Refs: nodejs#38839 (comment)

PR-URL: nodejs#38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

Trott force-pushed the lts branch from 01f85a2 to 58bd046 Compare

May 31, 2021 18:43

Member Author

Trott commented May 31, 2021

Landed in 16ae378...58bd046

Trott merged commit 58bd046 into nodejs:master

Trott deleted the lts branch

May 31, 2021 18:43

Contributor

bl-ue commented May 31, 2021 •

edited

Why does GH say that the PR was merged, rather than closed? It does that sometimes, but it's not clear to me why. 🤔

Member Author

Trott commented Jun 1, 2021

Why does GH say that the PR was merged, rather than closed? It does that sometimes, but it's not clear to me why. 🤔

If people follow the general procedure for this repo, it will end up Closed. However, there is an optional step that I always take where, before pushing the change to the master branch, you force-push it to the PR branch. Some users don't allow project collaborators to force push to their branches, but most do (as it's the default in GitHub--you have to uncheck a box when opening the pull request to prevent it). So if that works, it ends up being purple and merged, which people seem to appreciate and which I gather affects some tooling and GitHub stats in a positive way.

danielleadams pushed a commit that referenced this pull request


          doc: use "Long Term Support" in technical values doc

Use "Long Term Support" rather than "long term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

danielleadams pushed a commit that referenced this pull request


          doc: use "Long Term Support" in collaborator guide

131a691

Use "Long Term Support" rather than "Long-term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

danielleadams mentioned this pull request

v16.3.0 proposal #38874

Merged

Trott added a commit to nodejs/remark-preset-lint-node that referenced this pull request


          feat: add linting for "Long Term Support" (#185)

ed2fc29

Refs: nodejs/node#38841
Refs: nodejs/node#38839

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in technical values doc

559582c

Use "Long Term Support" rather than "long term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in collaborator guide

a84a661

Use "Long Term Support" rather than "Long-term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in technical values doc

6be19ad

Use "Long Term Support" rather than "long term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in collaborator guide

1d20713

Use "Long Term Support" rather than "Long-term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in technical values doc

7a9850a

Use "Long Term Support" rather than "long term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau pushed a commit that referenced this pull request


          doc: use "Long Term Support" in collaborator guide

b4f60bb

Use "Long Term Support" rather than "Long-term support".

Refs: #38839 (comment)

PR-URL: #38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

richardlau mentioned this pull request

v14.17.4 proposal #39466

Merged

foxxyz pushed a commit to foxxyz/node that referenced this pull request


          doc: use "Long Term Support" in technical values doc

5e1e1c1

Use "Long Term Support" rather than "long term support".

Refs: nodejs#38839 (comment)

PR-URL: nodejs#38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

foxxyz pushed a commit to foxxyz/node that referenced this pull request


          doc: use "Long Term Support" in collaborator guide

9c4f9a2

Use "Long Term Support" rather than "Long-term support".

Refs: nodejs#38839 (comment)

PR-URL: nodejs#38841
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

Marlyfleitas added a commit to Marlyfleitas/Node-remark-preset-lint that referenced this pull request


          feat: add linting for "Long Term Support" (#185)

3b906a6

Refs: nodejs/node#38841
Refs: nodejs/node#38839

patrickm68 added a commit to patrickm68/Node-preset-lint that referenced this pull request


          feat: add linting for "Long Term Support" (#185)

ca0be9d

Refs: nodejs/node#38841
Refs: nodejs/node#38839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

lpinca lpinca approved these changes

targos targos approved these changes

cjihrig cjihrig approved these changes

mhdawson mhdawson approved these changes

DerekNonGeneric DerekNonGeneric approved these changes

RaisinTen RaisinTen approved these changes

bl-ue bl-ue approved these changes