Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: use missing validator #38935

Closed
wants to merge 2 commits into from
Closed

vm: use missing validator #38935

wants to merge 2 commits into from

Conversation

VoltrexKeyva
Copy link
Member

The vm lib module's isContext() function should use a validator.

@VoltrexKeyva
vm: use missing validator
3550e92 
The `vm` lib module's `isContext()` function should use a validator.
@github-actions github-actions bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 4, 2021
@VoltrexKeyva
fixup! vm: use missing validator
1f98445 
Arrays are also passed to `isContext()` when used in the internals so its a good approach to allow arrays.
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38499/

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2021
jasnell pushed a commit that referenced this pull request Jun 7, 2021
@VoltrexKeyva @jasnell
vm: use missing validator
826566e 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: #38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 7, 2021

Landed in 826566e

@jasnell jasnell closed this Jun 7, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-6 branch June 7, 2021 14:43
targos pushed a commit that referenced this pull request Jun 11, 2021
@VoltrexKeyva @targos
vm: use missing validator
f40725f 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: #38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@VoltrexKeyva @richardlau
vm: use missing validator
2f72ca5 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: #38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@VoltrexKeyva @richardlau
vm: use missing validator
31359e1 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: #38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@VoltrexKeyva @richardlau
vm: use missing validator
dd00547 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: #38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@VoltrexKeyva @foxxyz
vm: use missing validator
9d40558 
The `vm` lib module's `isContext()` function should use a validator.

PR-URL: nodejs#38935
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@devsnek devsnek devsnek approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@ycjcl868 ycjcl868 ycjcl868 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@VoltrexKeyva @nodejs-github-bot @jasnell @addaleax @lpinca @devsnek @Lxxyx @ycjcl868 @RaisinTen @bl-ue