src: return Maybe<bool> from InitializeContextRuntime() #39695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src/return-Maybe-bool-fromInitializeContextRuntime
branch
from
a42dadf
to
5bd551a
Compare
addaleax
approved these changes
Aug 7, 2021
addaleax
added
author ready
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Aug 7, 2021
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39695 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 284f164 |
RaisinTen
deleted the
src/return-Maybe-bool-fromInitializeContextRuntime
branch
|
@RaisinTen do you mind backporting this to |
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
Aug 21, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: nodejs#39695 Backport-PR-URL: nodejs#39834 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com