Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] stream: add isDisturbed helper #39819

Closed
wants to merge 2 commits into from
Closed

[v16.x backport] stream: add isDisturbed helper #39819

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 20, 2021

No description provided.

@ronag ronag changed the title Backport 39628 to v16.x [v16.x backport] stream: add isDisturbed helper Aug 20, 2021
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 20, 2021
@ronag ronag changed the base branch from master to v16.x-staging August 20, 2021 13:30
ronag added a commit to nxtedition/node that referenced this pull request Aug 20, 2021
@ronag
stream: add isDisturbed helper
574bec6 
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).

Refs: nodejs#39627

PR-URL: nodejs#39628
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#39819
@ronag ronag mentioned this pull request Aug 20, 2021
Closed
@ronag
stream: add isDisturbed helper
cd6f6c8 
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).

Refs: nodejs#39627

PR-URL: nodejs#39628
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Backport-PR-URL: nodejs#39819
@ronag ronag requested a review from jasnell August 20, 2021 14:00
@ronag
Copy link
Member Author

ronag commented Aug 20, 2021

@nodejs/streams

@ronag ronag added stream Issues and PRs related to the stream subsystem. web streams labels Aug 20, 2021
mcollina
mcollina approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag @targos
Update lib/internal/streams/utils.js
fca6388 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39634/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39641/

@targos
Copy link
Member

targos commented Aug 23, 2021

I think this one will be easier to do after #39563 ?

@ronag
Copy link
Member Author

ronag commented Aug 23, 2021 •
edited
Loading

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

@ronag
Copy link
Member Author

ronag commented Aug 23, 2021

CI linting error on markdown which I can't figure out. 😕

@targos
Copy link
Member

targos commented Aug 23, 2021

I think this one will be easier to do after #39563 ?

Why? I don't think they are related? I think this can land now?

You're right. I'm mixing things

@targos
Copy link
Member

targos commented Aug 23, 2021

CI linting error on markdown which I can't figure out. 😕

It was because 0073831 was missing from v16.x-staging. It's there now.

targos pushed a commit that referenced this pull request Aug 23, 2021
@ronag @targos
stream: add isDisturbed helper
af7047a 
Adds a helper util used to determine whether a stream has been
disturbed (read or cancelled).

Refs: #39627

PR-URL: #39628
Backport-PR-URL: #39819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos
Copy link
Member

targos commented Aug 23, 2021

Landed in af7047a

@targos targos closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem. tools Issues and PRs related to the tools directory. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ronag @nodejs-github-bot @targos @mcollina @benjamingr