Fix: Invalid HTTP/2 origin set when servername is empty #39919 #39934

Narasimha1997 · 2021-08-29T16:17:36Z

The bug posted by @szmarczak is because of not checking the truthy value of options.servername in line 3101 and 3102 of lib/internal/http2/core.js, instead the options.servername is strictly checked against undefined, any value other than undefined will give undesirable result in this case.

So in this PR,

if (servername !== undefined && options.servername === undefined)
    options.servername = servername;

is changed to,

if (servername !== undefined && !options.servername)
    options.servername = servername;

Here, the truthy value of options.servername is checked rather than strict check against undefined.

I have built node.js locally and checked against the code posted by @szmarczak to reproduce the bug.

Ayase-252 · 2021-08-29T16:58:30Z

Could we add a test for the issue?

Narasimha1997 · 2021-08-29T17:07:48Z

@Ayase-252 yeah that would be great. I'll look into how tests are organised in this project so I can write few cases.

Narasimha1997 · 2021-08-29T18:45:56Z

@Ayase-252 I have added test cases.

szmarczak · 2021-08-29T20:45:14Z

@Narasimha1997 Lint fails. The commit message check fails too.

Mesteery · 2021-08-29T21:05:03Z

Commit message: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines.
Naming test files: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#naming-test-files.

Ayase-252

We could also run make -j4 test to do a full check on the codebase locally. Per https://github.com/nodejs/node/blob/master/BUILDING.md#running-tests

test/internet/test-http2-issue-39919.js

Narasimha1997 · 2021-08-30T03:30:32Z

@Mesteery @szmarczak @Ayase-252
Well, haha. Last time I made a contribution to Node an year ago, this commit message linting was not there. So what would you suggest? Can you please give an example of how issue fix commit message must be formulated?

Ayase-252 · 2021-08-30T04:26:55Z

@Narasimha1997

Maybe

http2: set origin name correctly when servername is empty

Fixes: https://github.com/nodejs/node/issues/39919

Fixes: nodejs#39919

lib/internal/http2/core.js

Narasimha1997 · 2021-08-31T02:17:17Z

The build on windows has failed due to some issues while fetching NASM. Can we re-run the build? Now it seems to be working fine.

lpinca · 2021-08-31T17:21:53Z

lib/internal/http2/core.js

@@ -3098,7 +3098,7 @@ function initializeTLSOptions(options, servername) {
  options.ALPNProtocols = ['h2'];
  if (options.allowHTTP1 === true)
    ArrayPrototypePush(options.ALPNProtocols, 'http/1.1');
-  if (servername !== undefined && options.servername === undefined)
+  if (servername !== undefined && !options.servername)


I don't know it makes sense for http2 but for https the empty string is used to disable the SNI extension. I wonder if the same should be done here.

cc: @nodejs/http2

Thanks. Yeah that makes sense. This PR is based in what the issue poster has expected to be the intended behaviour. If you confirm SNI should be disabled, I would be happy to make these changes.

lpinca · 2021-08-31T17:26:19Z

test/internet/test-http2-https-origin-string-correctness.js

+}
+
+function withServerName() {
+  const session = http2.connect('https://1.1.1.1', { servername: 'cloudflare-dns.com' });


This requires an external connection. Is it possible to use localhost? See #39011.

Edit: This is not a blocker. The test is under test/internet so it should be ok as is.

mcollina

I would prefer this test to not use the Internet. Is there a specific reason it should?

Fixes: nodejs#39919 Refs: nodejs#39934

Fixes: #39919 Refs: #39934 PR-URL: #42838 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Fixes: nodejs/node#39919 Refs: nodejs/node#39934 PR-URL: nodejs/node#42838 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Aug 29, 2021

Narasimha1997 mentioned this pull request Aug 29, 2021

Invalid HTTP/2 origin set when servername is empty #39919

Closed

Ayase-252 reviewed Aug 30, 2021

View reviewed changes

test/internet/test-http2-issue-39919.js Outdated Show resolved Hide resolved

test/internet/test-http2-issue-39919.js Outdated Show resolved Hide resolved

http2: set origin name correctly when servername is empty

c43b614

Fixes: nodejs#39919

Narasimha1997 force-pushed the fix-invalid-origin-set branch from 74b149d to c43b614 Compare August 30, 2021 11:12

szmarczak reviewed Aug 30, 2021

View reviewed changes

lib/internal/http2/core.js Show resolved Hide resolved

lpinca reviewed Aug 31, 2021

View reviewed changes

mcollina reviewed Aug 31, 2021

View reviewed changes

ofirbarak pushed a commit to ofirbarak/node that referenced this pull request Apr 23, 2022

http2: set origin name correctly when servername is empty

90bb546

Fixes: nodejs#39919 Refs: nodejs#39934

ofirbarak mentioned this pull request Apr 23, 2022

http2: set origin name correctly when servername is empty #42838

Merged

ofirbarak pushed a commit to ofirbarak/node that referenced this pull request May 22, 2022

http2: set origin name correctly when servername is empty

10cb6da

Fixes: nodejs#39919 Refs: nodejs#39934

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Invalid HTTP/2 origin set when servername is empty #39919 #39934

Fix: Invalid HTTP/2 origin set when servername is empty #39919 #39934

Narasimha1997 commented Aug 29, 2021 •

edited

Loading

Ayase-252 commented Aug 29, 2021

Narasimha1997 commented Aug 29, 2021

Narasimha1997 commented Aug 29, 2021

szmarczak commented Aug 29, 2021

Mesteery commented Aug 29, 2021

Ayase-252 left a comment

Narasimha1997 commented Aug 30, 2021 •

edited

Loading

Ayase-252 commented Aug 30, 2021

Narasimha1997 commented Aug 31, 2021

lpinca Aug 31, 2021 •

edited

Loading

Narasimha1997 Sep 1, 2021

lpinca Aug 31, 2021 •

edited

Loading

mcollina left a comment

Fix: Invalid HTTP/2 origin set when servername is empty #39919 #39934

Are you sure you want to change the base?

Fix: Invalid HTTP/2 origin set when servername is empty #39919 #39934

Conversation

Narasimha1997 commented Aug 29, 2021 • edited Loading

Ayase-252 commented Aug 29, 2021

Narasimha1997 commented Aug 29, 2021

Narasimha1997 commented Aug 29, 2021

szmarczak commented Aug 29, 2021

Mesteery commented Aug 29, 2021

Ayase-252 left a comment

Choose a reason for hiding this comment

Narasimha1997 commented Aug 30, 2021 • edited Loading

Ayase-252 commented Aug 30, 2021

Narasimha1997 commented Aug 31, 2021

lpinca Aug 31, 2021 • edited Loading

Choose a reason for hiding this comment

Narasimha1997 Sep 1, 2021

Choose a reason for hiding this comment

lpinca Aug 31, 2021 • edited Loading

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

Narasimha1997 commented Aug 29, 2021 •

edited

Loading

Narasimha1997 commented Aug 30, 2021 •

edited

Loading

lpinca Aug 31, 2021 •

edited

Loading

lpinca Aug 31, 2021 •

edited

Loading