Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify getAuthTag with authTagLength #40713

Closed
wants to merge 1 commit into from
Closed

doc: clarify getAuthTag with authTagLength #40713

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 3, 2021

This behavior is only documented in createCipheriv and createCipher, but should also be mentioned in getAuthTag.

Refs: #40272
Refs: #20235

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 3, 2021
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2021
@tniessen
Copy link
Member Author

tniessen commented Nov 8, 2021

I'm not sure what's going on with the commit queue.

@targos
Copy link
Member

targos commented Nov 8, 2021

The commit queue is blocked on nodejs/admin#640

@targos
Copy link
Member

targos commented Nov 9, 2021

Landed in dd60161

targos pushed a commit that referenced this pull request Nov 9, 2021
@tniessen @targos
doc: clarify getAuthTag with authTagLength
dd60161 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos closed this Nov 9, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
@tniessen @targos
doc: clarify getAuthTag with authTagLength
20d7d65 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@tniessen @danielleadams
doc: clarify getAuthTag with authTagLength
23d188f 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@tniessen @danielleadams
doc: clarify getAuthTag with authTagLength
7f9bf21 
Refs: #40272
Refs: #20235

PR-URL: #40713
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tniessen @targos @panva @Trott @lpinca @nodejs-github-bot