Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix non readable Duplex readableAborted #40801

Closed
wants to merge 4 commits into from
Closed

stream: fix non readable Duplex readableAborted #40801

wants to merge 4 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 13, 2021 •
edited
Loading

Fixes: #40800

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Nov 13, 2021
@ronag ronag requested a review from mcollina November 13, 2021 13:04
@ronag
Copy link
Member Author

ronag commented Nov 13, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 13, 2021
@ronag ronag requested a review from lpinca November 13, 2021 16:26
@ronag ronag removed the needs-ci PRs that need a full CI run. label Nov 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40866/

mcollina
mcollina approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Nov 14, 2021
Open
Open
@ronag
Copy link
Member Author

ronag commented Nov 15, 2021

Landed in 640bfb8

@ronag ronag closed this Nov 15, 2021
ronag added a commit that referenced this pull request Nov 15, 2021
@ronag
stream: fix non readable Duplex readableAborted
640bfb8 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Nov 16, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@ronag @targos
stream: fix non readable Duplex readableAborted
7d127d2 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag @danielleadams
stream: fix non readable Duplex readableAborted
218ada9 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag @danielleadams
stream: fix non readable Duplex readableAborted
55c9349 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non readable Duplex should not be readableAborted
6 participants
@ronag @nodejs-github-bot @mcollina @jasnell @lpinca @juanarbol