Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix checking syntax of esm module #41198

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented Dec 16, 2021

A internal function defaultGetFormat was changed in #37468. Update the call in check_syntax.js accordingly.

Fixes: #41189
Refs: #37468

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 16, 2021
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done — it seems like that function invocation should not have been getting destructed — pretty sure that's a good catch and the fix there.

Apologies from @nodejs/loaders (it wasn't me tho). ;)

@JakobJingleheimer
Copy link
Contributor

JakobJingleheimer commented Dec 16, 2021

Mea culpa 😣

I did a search on the repo and all tests were passing, so I figured all was 👍

Thanks for catching

@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2021
@DerekNonGeneric DerekNonGeneric added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@DerekNonGeneric DerekNonGeneric added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot merged commit 3f7dabd into nodejs:master Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 3f7dabd

@Ayase-252 Ayase-252 deleted the fix/lib/esm-syntax-check branch December 20, 2021 05:52
@JakobJingleheimer JakobJingleheimer mentioned this pull request Dec 28, 2021
9 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Fixes: nodejs#41189

PR-URL: nodejs#41198
Refs: nodejs#37468
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Fixes: #41189

PR-URL: #41198
Refs: #37468
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node --check does not support ESM on Node.js 16
10 participants