Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-gc-http-client-onerror to sequential #41619

Merged
merged 1 commit into from
Jan 22, 2022
Merged

test: move test-gc-http-client-onerror to sequential #41619

merged 1 commit into from
Jan 22, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 20, 2022

Fixes: #41399

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 20, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 21, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42066/

@github-actions github-actions bot mentioned this pull request Jan 22, 2022
Open
17 tasks
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit d01c645 into nodejs:master Jan 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d01c645

@lpinca lpinca deleted the move/test-gc-http-client-onerror-to-sequential branch January 22, 2022 19:33
This was referenced Jan 23, 2022
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@lpinca @BethGriggs
test: move test-gc-http-client-onerror to sequential
ea6c202 
Fixes: #41399

PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@lpinca @Linkgoron
test: move test-gc-http-client-onerror to sequential
4b32536 
Fixes: nodejs#41399

PR-URL: nodejs#41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@lpinca @danielleadams
test: move test-gc-http-client-onerror to sequential
ac4288c 
Fixes: #41399

PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@lpinca @danielleadams
test: move test-gc-http-client-onerror to sequential
4c5e0ba 
Fixes: #41399

PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@lpinca @danielleadams
test: move test-gc-http-client-onerror to sequential
fbaf1dc 
Fixes: #41399

PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@lpinca @danielleadams
test: move test-gc-http-client-onerror to sequential
950648d 
Fixes: #41399

PR-URL: #41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test - test-gc-http-client-onerror.js
5 participants
@lpinca @nodejs-github-bot @Trott @santigimeno @cjihrig