Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update property name #42398

Merged
merged 1 commit into from
Mar 21, 2022
Merged

doc: update property name #42398

merged 1 commit into from
Mar 21, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 19, 2022

Property name min was updated in 23637e9
to lowest but an instance of min was missed.

@Trott
doc: update property name
cacca4a 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.
@Trott Trott requested a review from jasnell March 19, 2022 02:07
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Mar 19, 2022
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2022
Bilalssbb
Bilalssbb reviewed Mar 19, 2022
View reviewed changes
Copy link

@Bilalssbb Bilalssbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc: update property name

Bilalssbb
Bilalssbb reviewed Mar 19, 2022
View reviewed changes
Copy link

@Bilalssbb Bilalssbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc: update property name

@Trott
Copy link
Member Author

Trott commented Mar 19, 2022

doc: update property name

User blocked.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4e2fefc into master Mar 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4e2fefc

@Trott Trott deleted the Trott-patch-1 branch March 21, 2022 05:29
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@Trott @juanarbol
doc: update property name
056ae57 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@Trott @juanarbol
doc: update property name
07b38f6 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@Trott @juanarbol
doc: update property name
10d638a 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
doc: update property name
8a534be 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
doc: update property name
a197ad9 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
doc: update property name
516a40d 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
doc: update property name
ae764ae 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
doc: update property name
165ee28 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
doc: update property name
c4f3729 
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs/node#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bilalssbb Bilalssbb Bilalssbb left review comments

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@Mesteery Mesteery Mesteery approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Trott @nodejs-github-bot @lpinca @cjihrig @tniessen @richardlau @HarshithaKP @Mesteery @Bilalssbb