nodejs/node#3111 - v8BreakIterator disablement #4253

srl295 · 2015-12-12T01:21:25Z

Getting this going… need to rebase

srl295 · 2015-12-12T01:35:34Z

Rebased. Problem, it doesn't actually work. My changes to src/node.js Don't seem to have effect after rebase.

Fishrock123 · 2015-12-14T17:51:15Z

linking: #3111

srl295 · 2016-04-09T02:36:54Z

OK, it's working again. Can I get a LGTM?

srl295 · 2016-04-09T02:42:32Z

To test:
node -e 'new Intl.v8BreakIterator()'

before: crashes in small-icu (which is our default)
after: no crash

$ ./node -e 'new Intl.v8BreakIterator()'
internal/process.js:72
        throw Error('Data not available...'); 
        ^
Error: Data not available...
    at Error (native)
    at new v8BreakIterator (internal/process.js:72:15)
    at [eval]:1:1
    at Object.exports.runInThisContext (vm.js:54:17)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:416:34)
    at node.js:317:27
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

srl295 · 2016-04-09T02:46:36Z

add test

Question: what's the best way to test this?

bnoordhuis · 2016-04-09T10:29:30Z

lib/internal/process.js

@@ -65,6 +65,13 @@ function setupConfig(_source) {
    if (value === 'false') return false;
    return value;
  });
+  if ( process.config.variables.v8_enable_i18n_support && global.hasOwnProperty('Intl') 


Style error: space after (. Can you put each check on its own line, followed by the &&? You'll also need to start with:

if (process.config && process.config.variables && // ...

Thanks. I'll drop the check for process.config.variables.v8_enable_i18n_support also. For this code's purpose, checking Intl is enough. One fewer dependency on an internal v8 variable is better.

srl295 · 2016-04-11T16:33:12Z

Updated, PTAL

bnoordhuis · 2016-04-11T16:48:09Z

lib/internal/process.js

+  // 
+  if (global.hasOwnProperty('Intl') &&
+      Intl.hasOwnProperty('v8BreakIterator') &&
+      process.config.variables.icu_small &&


You still need a process.config && process.config.variables feature check here and can you make sure make lint passes?

srl295 · 2016-04-11T17:47:56Z

linter happy
test updated

bnoordhuis · 2016-04-11T18:56:26Z

lib/internal/process.js

+  // Intl.v8BreakIterator() would crash v8 with a nastygram here, throw instead.
+  if (global.hasOwnProperty('Intl') &&
+      Intl.hasOwnProperty('v8BreakIterator') &&
+      process.config.variables.icu_small &&


Needs a process.config && process.config.variables feature check.

srl295 · 2016-05-03T21:39:34Z

Updated, rebased. Thanks @jasnell

If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes nodejs#3111

jasnell · 2016-05-03T21:45:39Z

LGTM if CI is green :-)

srl295 · 2016-05-03T22:29:56Z

ci build in progress…

srl295 · 2016-05-03T23:31:29Z

CI green https://ci.nodejs.org/job/node-test-pull-request/2489/

If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes: #3111 PR-URL: #4253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

srl295 · 2016-05-04T22:07:05Z

Landed in cd752e8

If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes: #3111 PR-URL: #4253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2016-06-01T22:03:56Z

@srl295 this does not land cleanly on v4.x would you be willing to manually backport?

srl295 · 2016-06-01T22:23:05Z

Yes. Probably an earlier version would. Or maybe depend on back porting the other process change @jasnell ?

MylesBorins · 2016-06-29T16:28:17Z

@srl295 / @jasnell ping

MylesBorins · 2016-08-30T14:10:50Z

@srl295 ping

srl295 · 2016-10-10T16:51:08Z

#9008 is the v4.x backport.

If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes: #3111 Ref: #9008 PR-URL: #4253 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

srl295 force-pushed the nobreak branch 2 times, most recently from 81c275d to d8b0b26 Compare December 12, 2015 01:30

srl295 self-assigned this Dec 12, 2015

srl295 added the wip Issues and PRs that are still a work in progress. label Dec 12, 2015

mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 12, 2015

jasnell added the lts-watch-v4.x label Dec 12, 2015

Trott force-pushed the master branch from 1e896a6 to 082cc8d Compare December 27, 2015 02:01

srl295 force-pushed the nobreak branch from d8b0b26 to 7f4b051 Compare April 9, 2016 02:33

srl295 added i18n-api Issues and PRs related to the i18n implementation. and removed wip Issues and PRs that are still a work in progress. labels Apr 9, 2016

srl295 force-pushed the nobreak branch from 7f4b051 to 21655f2 Compare April 9, 2016 02:57

bnoordhuis reviewed Apr 9, 2016
View reviewed changes

srl295 force-pushed the nobreak branch from 21655f2 to 17cc0ac Compare April 11, 2016 16:31

bnoordhuis reviewed Apr 11, 2016
View reviewed changes

srl295 force-pushed the nobreak branch from 17cc0ac to e94308e Compare April 11, 2016 17:47

bnoordhuis reviewed Apr 11, 2016
View reviewed changes

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:22

srl295 force-pushed the nobreak branch from 4dfe98d to de0f910 Compare May 3, 2016 21:39

intl: Don't crash if v8BreakIterator not available

c99f231

If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes nodejs#3111

srl295 force-pushed the nobreak branch from de0f910 to c99f231 Compare May 3, 2016 21:40

srl295 closed this May 4, 2016

srl295 deleted the nobreak branch May 4, 2016 22:07

evanlucas mentioned this pull request May 17, 2016

2016-05-17, Version 6.2.0 (Stable) #6810

Merged

srl295 changed the title ~~nodejs/node#3111 - WIP v8BreakIterator disablement~~ nodejs/node#3111 - v8BreakIterator disablement Oct 10, 2016

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Oct 10, 2016

MylesBorins mentioned this pull request Oct 26, 2016

V4.6.2 proposal #9298

Closed

TimothyGu mentioned this pull request Aug 18, 2017

Calling Intl.v8BreakIterator w/o ICU data in VM context makes the process crash #14909

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nodejs/node#3111 - v8BreakIterator disablement #4253

nodejs/node#3111 - v8BreakIterator disablement #4253

srl295 commented Dec 12, 2015

srl295 commented Dec 12, 2015

Fishrock123 commented Dec 14, 2015

srl295 commented Apr 9, 2016

srl295 commented Apr 9, 2016

srl295 commented Apr 9, 2016

bnoordhuis Apr 9, 2016

srl295 Apr 11, 2016

srl295 commented Apr 11, 2016

bnoordhuis Apr 11, 2016

srl295 commented Apr 11, 2016

bnoordhuis Apr 11, 2016

srl295 commented May 3, 2016

jasnell commented May 3, 2016

srl295 commented May 3, 2016

srl295 commented May 3, 2016

srl295 commented May 4, 2016

MylesBorins commented Jun 1, 2016

srl295 commented Jun 1, 2016 •

edited

MylesBorins commented Jun 29, 2016

MylesBorins commented Aug 30, 2016

srl295 commented Oct 10, 2016

nodejs/node#3111 - v8BreakIterator disablement #4253

nodejs/node#3111 - v8BreakIterator disablement #4253

Conversation

srl295 commented Dec 12, 2015

srl295 commented Dec 12, 2015

Fishrock123 commented Dec 14, 2015

srl295 commented Apr 9, 2016

srl295 commented Apr 9, 2016

srl295 commented Apr 9, 2016

bnoordhuis Apr 9, 2016

Choose a reason for hiding this comment

srl295 Apr 11, 2016

Choose a reason for hiding this comment

srl295 commented Apr 11, 2016

bnoordhuis Apr 11, 2016

Choose a reason for hiding this comment

srl295 commented Apr 11, 2016

bnoordhuis Apr 11, 2016

Choose a reason for hiding this comment

srl295 commented May 3, 2016

jasnell commented May 3, 2016

srl295 commented May 3, 2016

srl295 commented May 3, 2016

srl295 commented May 4, 2016

MylesBorins commented Jun 1, 2016

srl295 commented Jun 1, 2016 • edited

MylesBorins commented Jun 29, 2016

MylesBorins commented Aug 30, 2016

srl295 commented Oct 10, 2016

srl295 commented Jun 1, 2016 •

edited