Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add configure option --v8-enable-short-builtin-calls #42688

Closed
wants to merge 1 commit into from
Closed

build: add configure option --v8-enable-short-builtin-calls #42688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,13 @@
help='Enable V8 transparent hugepage support. This feature is only '+
'available on Linux platform.')

parser.add_argument('--v8-enable-short-builtin-calls',
action='store_true',
dest='v8_enable_short_builtin_calls',
default=None,
help='Enable V8 short builtin calls support. This feature is enabled '+
'on x86_64 platform by default.')

parser.add_argument('--node-builtin-modules-path',
action='store',
dest='node_builtin_modules_path',
Expand Down Expand Up @@ -1464,6 +1471,8 @@ def configure_v8(o):
if flavor != 'linux' and options.v8_enable_hugepage:
raise Exception('--v8-enable-hugepage is supported only on linux.')
o['variables']['v8_enable_hugepage'] = 1 if options.v8_enable_hugepage else 0
if options.v8_enable_short_builtin_calls or o['variables']['target_arch'] == 'x64':
o['variables']['v8_enable_short_builtin_calls'] = 1

def configure_openssl(o):
variables = o['variables']
Expand Down
6 changes: 6 additions & 0 deletions tools/v8_gypfiles/features.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@
'v8_enable_pointer_compression%': 0,
'v8_enable_31bit_smis_on_64bit_arch%': 0,

# Sets -dV8_SHORT_BUILTIN_CALLS
'v8_enable_short_builtin_calls%': 0,

# Sets -dOBJECT_PRINT.
'v8_enable_object_print%': 0,

Expand Down Expand Up @@ -294,6 +297,9 @@
['v8_enable_pointer_compression==1 or v8_enable_31bit_smis_on_64bit_arch==1', {
'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH',],
}],
['v8_enable_short_builtin_calls==1', {
'defines': ['V8_SHORT_BUILTIN_CALLS',],
}],
['v8_enable_zone_compression==1', {
'defines': ['V8_COMPRESS_ZONES',],
}],
Expand Down