doc: amend support tier qualifier #42805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
mhdawson
reviewed
Apr 21, 2022
RaisinTen
reviewed
Apr 22, 2022
gireeshpunathil
force-pushed
the
support-tiers-tier3-define
branch
from
3ff7a3e
to
e4da26e
Compare
|
this can have more reviews. |
RaisinTen
approved these changes
Mar 12, 2023
gireeshpunathil
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42805 ✔ Done loading data for nodejs/node/pull/42805 ----------------------------------- PR info ------------------------------------ Title doc: amend support tier qualifier (#42805) Author Gireesh Punathil (@gireeshpunathil) Branch gireeshpunathil:support-tiers-tier3-define -> nodejs:main Labels doc Commits 2 - doc: amend support tier qualifier - fixup: reword based on review comments Committers 1 - Gireesh Punathil PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Apr 2022 04:46:33 GMT ✔ Approvals: 3 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-948787072 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336000383 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336014453 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 42805 From https://github.com/nodejs/node * branch refs/pull/42805/merge -> FETCH_HEAD ✔ Fetched commits as 7f2ab4e62985..e4da26ed9005 -------------------------------------------------------------------------------- [main 7e2d9f14fd] doc: amend support tier qualifier Author: Gireesh Punathil Date: Thu Apr 21 10:11:32 2022 +0530 1 file changed, 4 insertions(+), 3 deletions(-) [main 6ffb3148ac] fixup: reword based on review comments Author: Gireesh Punathil Date: Sat Mar 11 19:01:42 2023 +0530 1 file changed, 3 insertions(+), 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4397476877 |
gireeshpunathil
added
the
commit-queue-squash
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: nodejs#42802
gireeshpunathil
force-pushed
the
support-tiers-tier3-define
branch
from
e4da26e
to
d5b971f
Compare
gireeshpunathil
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42805 ✔ Done loading data for nodejs/node/pull/42805 ----------------------------------- PR info ------------------------------------ Title doc: amend support tier qualifier (#42805) Author Gireesh Punathil (@gireeshpunathil) Branch gireeshpunathil:support-tiers-tier3-define -> nodejs:main Labels doc Commits 1 - doc: amend support tier qualifier Committers 1 - Gireesh Punathil PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42805 Refs: https://github.com/nodejs/node/pull/42802 Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: amend support tier qualifier ℹ This PR was created on Thu, 21 Apr 2022 04:46:33 GMT ✔ Approvals: 3 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-948787072 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336000383 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42805#pullrequestreview-1336014453 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4398393764 |
cjihrig
approved these changes
Mar 13, 2023
gireeshpunathil
added a commit
that referenced
this pull request
Mar 13, 2023
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
landed in 59dd9ca |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.
Refs: #42802