doc: use serial comma in tls docs #43001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Trott
approved these changes
May 7, 2022
Trott
reviewed
May 7, 2022
Comment on lines
+1644
to
+1645
| An array of strings, `Buffer`s, `TypedArray`s, or `DataView`s, or a | ||
| single `Buffer`, `TypedArray`, or `DataView` containing the supported ALPN |
There was a problem hiding this comment.
Doesn't have to be in this PR, but it's probably worth finding another way to express this, or maybe removing the list of possible types entirely as the types are described immediately above.
VoltrexKeyva
approved these changes
May 7, 2022
lpinca
approved these changes
May 7, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 58d8d69 |
Merged
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#43001 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node/doc/README.md
Line 21 in 5e9274a
Refs: #11321
Refs: #17384