Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix static analysis warning and use smart ptr #43117

Merged
merged 1 commit into from
May 18, 2022
Merged

src: fix static analysis warning and use smart ptr #43117

merged 1 commit into from
May 18, 2022

Commits on May 16, 2022

  1. src: fix static analysis warning and use smart ptr 

    Coverity issues a warning about `value_before_reset == ca`, where
value_before_reset is a pointer that may not be valid. While comparing
the pointer itself should still work, we should really be using smart
pointers here so that this particular check can be simplified without
running into a memory leak.

Refactor SSL_CTX_get_issuer to return a smart pointer and update the
call sites accordingly. Note that we might have to change that in the
future once we improve error handling throughout crypto/tls.

Refs: nodejs#37990
    @tniessen
    tniessen committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3bd3bba View commit details
    Browse the repository at this point in the history