deps: update V8 to 10.3 #43195

targos · 2022-05-24T05:06:56Z

No description provided.

nodejs-github-bot · 2022-05-24T05:07:01Z

Review requested:

@nodejs/v8-update

nodejs-github-bot · 2022-05-24T05:08:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44144/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/

targos · 2022-05-24T05:12:35Z

@nodejs/platform-s390

https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/nodes=rhel8-s390x,v8test=v8test/console

07:10:31 Errors:
07:10:31   failed to resolve gn/gn/linux-s390x@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-s390x
07:10:31 Error: Command 'cipd ensure -log-level error -root . -ensure-file /tmp/tmpnPxX9U.ensure' returned non-zero exit status 1
07:10:31 Errors:
07:10:31   failed to resolve gn/gn/linux-s390x@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-s390x
07:10:31

targos · 2022-05-24T05:13:49Z

@nodejs/platform-ppc

https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/nodes=rhel8-ppc64le,v8test=v8test/console

07:12:30 Errors:
07:12:30   failed to resolve gn/gn/linux-ppc64le@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-ppc64le
07:12:30 Error: Command 'cipd ensure -log-level error -root . -ensure-file /tmp/tmpPxPhU7.ensure' returned non-zero exit status 1
07:12:30 Errors:
07:12:30   failed to resolve gn/gn/linux-ppc64le@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-ppc64le
07:12:30

targos · 2022-05-24T06:08:45Z

@nodejs/build

https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

07:29:32 ../../third_party/llvm-build/Release+Asserts/bin/clang++: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by ../../third_party/llvm-build/Release+Asserts/bin/clang++)

I think it's related to nodejs/build#2656

targos · 2022-05-24T06:13:16Z

@nodejs/platform-windows

We also have an error with the Windows debug build (already detected in nodejs/node-v8#223 (comment)).

https://ci.nodejs.org/job/node-compile-windows-debug/11984/nodes=win-vs2019/console

07:38:37 > "Debug\node.exe" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory=test\addons\hello-world --nodedir="C:\workspace\node-compile-windows-debug\node" 
07:38:37 
07:38:37 > if errorlevel 1 exit /b 
07:38:37 
07:38:37 > Debug\node.exe test\addons\hello-world\test.js 
07:38:37 

07:38:38 > exit -1073741819

targos · 2022-05-24T06:14:38Z

And a segfault while running the doc generator on @nodejs/platform-s390

https://ci.nodejs.org/job/node-test-commit-linuxone/32196/nodes=rhel8-s390x/console

07:39:36 /bin/sh: line 4: 2897915 Segmentation fault      (core dumped) /home/iojs/build/workspace/node-test-commit-linuxone/./node tools/doc/generate.mjs --node-version=v19.0.0 --apilinks=out/doc/apilinks.json doc/api/assert.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json
07:41:11 make[2]: *** [Makefile:777: out/doc/api/assert.html] Error 139

targos · 2022-05-24T11:07:22Z

Many test failures in debug mode: https://ci.nodejs.org/job/node-test-commit-arm-debug/2185/

#
# Fatal error in ../deps/v8/src/api/api.cc, line 8329
# Debug check failed: !i_isolate->is_execution_terminating().
#
#
#
#FailureMessage Object: 0xffff8dbf39b8
 1: 0xaaaadf895768 node::DumpBacktrace(_IO_FILE*) [out/Debug/node]
 2: 0xaaaadfa52274  [out/Debug/node]
 3: 0xaaaadfa522a0  [out/Debug/node]
 4: 0xaaaae1321554 V8_Fatal(char const*, int, char const*, ...) [out/Debug/node]
 5: 0xaaaae1321580 V8_Dcheck(char const*, int, char const*) [out/Debug/node]
 6: 0xaaaadfc4fdc8 v8::Integer::NewFromUnsigned(v8::Isolate*, unsigned int) [out/Debug/node]
 7: 0xaaaadf9b2af0 node::http2::Http2Session::OnStreamClose(nghttp2_session*, int, unsigned int, void*) [out/Debug/node]

targos · 2022-05-24T11:08:26Z

And a build timeout on rhel8-x64: https://ci.nodejs.org/job/node-test-commit-linux/45879/nodes=rhel8-x64/console

richardlau · 2022-05-24T11:28:32Z

@nodejs/platform-s390

https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/nodes=rhel8-s390x,v8test=v8test/console

07:10:31 Errors:
07:10:31   failed to resolve gn/gn/linux-s390x@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-s390x
07:10:31 Error: Command 'cipd ensure -log-level error -root . -ensure-file /tmp/tmpnPxX9U.ensure' returned non-zero exit status 1
07:10:31 Errors:
07:10:31   failed to resolve gn/gn/linux-s390x@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-s390x
07:10:31

@nodejs/platform-ppc

https://ci.nodejs.org/job/node-test-commit-v8-linux/4696/nodes=rhel8-ppc64le,v8test=v8test/console

07:12:30 Errors:
07:12:30   failed to resolve gn/gn/linux-ppc64le@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-ppc64le
07:12:30 Error: Command 'cipd ensure -log-level error -root . -ensure-file /tmp/tmpPxPhU7.ensure' returned non-zero exit status 1
07:12:30 Errors:
07:12:30   failed to resolve gn/gn/linux-ppc64le@git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35 (line 4): no such package: gn/gn/linux-ppc64le
07:12:30

That's this change: v8/v8@e3addb6
AFAIK Google do not host s390x nor ppc64le gn binaries so they're not expected to be there -- we compile gn ourselves when setting up the Node.js Linux s390x and ppc64le CI hosts. This bit of the V8 build was "working" before as previously the DEPS always specified the linux-amd64 variant to download:

node/deps/v8/DEPS

Line 94 in 38a3914

'package': 'gn/gn/linux-amd64',

@miladfarca @john-yan maybe https://github.com/targos/node/blob/95ed859f0fd5e6d842c5277e3866faa2a54daaac/deps/v8/DEPS#L107 needs to add checks for the specific architectures that Google host binaries for in addition to 'host_os == "linux"'?

miladfarca · 2022-05-24T14:44:38Z

I can't reproduce the segfault on s390 after multiple 10k runs. Is it possible to rerun the test?

For the gn issue, we have other cipd packages which don't exist and fail during fetch, we have a work item to skip them on ppc/s390.

Let me know if it's not possible to skip it on Node.js, we can instead patch v8 and backport.

richardlau · 2022-05-24T18:14:55Z

I can't reproduce the segfault on s390 after multiple 10k runs. Is it possible to rerun the test?

For the gn issue, it should be safe to ignore it as we have other cipd packages which don't exist and fail during fetch, we have a work item to skip them on ppc/s390.

Let me know if it's not possible to ignore it on Node.js, we can instead patch v8 and backport.

https://ci.nodejs.org/job/node-test-commit-v8-linux/4701/ passes on ppc64le/s390x with richardlau@89b07c0. If we don't want to upstream to V8 (why?) I think we'd need to modify fetch_deps.py on the Node.js side to conditionally add buildtools/linux64: None for ppc64le/s390x to

node/tools/v8/fetch_deps.py

Lines 21 to 46 in 4a3ba87

    
           GCLIENT_SOLUTION = [ 
        
             { "name"        : "v8", 
        
               "url"         : "https://chromium.googlesource.com/v8/v8.git", 
        
               "deps_file"   : "DEPS", 
        
               "managed"     : False, 
        
               "custom_deps" : { 
        
                 # These deps are already part of Node.js. 
        
                 "v8/base/trace_event/common"            : None, 
        
                 # These deps are unnecessary for building. 
        
                 "v8/test/benchmarks/data"               : None, 
        
                 "v8/testing/gmock"                      : None, 
        
                 "v8/test/mozilla/data"                  : None, 
        
                 "v8/test/test262/data"                  : None, 
        
                 "v8/test/test262/harness"               : None, 
        
                 "v8/third_party/android_ndk"            : None, 
        
                 "v8/third_party/android_sdk"            : None, 
        
                 "v8/third_party/catapult"               : None, 
        
                 "v8/third_party/colorama/src"           : None, 
        
                 "v8/third_party/fuchsia-sdk"            : None, 
        
                 "v8/third_party/instrumented_libraries" : None, 
        
                 "v8/tools/luci-go"                      : None, 
        
                 "v8/tools/swarming_client"              : None, 
        
                 "v8/third_party/qemu-linux-x64"         : None, 
        
               }, 
        
             }, 
        
           ]

miladfarca · 2022-05-24T18:44:21Z

I think the reason you are not seeing other package failures on ppc/s390 is because they get pulled during fetch v8 or gclient sync, these dependencies are part of depot_tools.
The gn error happens after V8 is pulled and during dependency check of V8 itself.

I'll make a CL to disable it like you have done and then it can be cherry picked.

miladfarca · 2022-05-26T20:16:56Z

GN fix is added to main branch and backported to 10.3 : https://chromium-review.googlesource.com/c/v8/v8/+/3666246
@richardlau thank you for your help.

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 10.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Co-Authored-By: Richard Lau <rlau@redhat.com>

This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: nodejs#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs#42375 PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Remove call to `memfd_create`. The function that references it is only used for V8 testing. PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Refs: v8/v8@3ae4277

nodejs-github-bot · 2022-05-27T13:43:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44194/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4705/

targos · 2022-07-12T06:30:03Z

I'll open a new PR when canary is fixed.

targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels May 24, 2022

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 24, 2022

targos added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label May 24, 2022

This was referenced May 25, 2022

CI Reliability 2022-05-25 nodejs/reliability#288

Open

CI Reliability 2022-05-26 nodejs/reliability#289

Open

targos and others added 10 commits May 27, 2022 15:35

deps: update V8 to 10.3.174.8

97fba1d

build: reset embedder string to "-node.0"

79a3749

src: update NODE_MODULE_VERSION to 109

764588d

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 10.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: disable trap handler for Windows cross-compiler

9b4c8bc

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

deps: silence V8's warning on CompileFunction

5d11708

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: nodejs#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added 4 commits May 27, 2022 15:36

deps: silence irrelevant V8 warning

9e23473

deps: bump minimum ICU version to 71

8478db2

Refs: v8/v8@3ae4277

tools: update V8 gypfiles for 10.3

0409f80

src: use non-deprecated V8 inspector API

e613f30

targos force-pushed the v8-103 branch from 95ed859 to e613f30 Compare May 27, 2022 13:38

This was referenced May 28, 2022

CI Reliability 2022-05-28 nodejs/reliability#291

Open

CI Reliability 2022-05-29 nodejs/reliability#292

Open

CI Reliability 2022-05-30 nodejs/reliability#293

Open

CI Reliability 2022-05-31 nodejs/reliability#294

Open

targos mentioned this pull request May 31, 2022

DCHECK crash on !i_isolate->is_execution_terminating() nodejs/node-v8#227

Closed

github-actions bot mentioned this pull request Jun 1, 2022

CI Reliability 2022-06-01 nodejs/reliability#295

Open

17 tasks

targos mentioned this pull request Jun 29, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-06-29 nodejs/TSC#1249

Closed

targos mentioned this pull request Jul 6, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-07-06 nodejs/TSC#1253

Closed

targos closed this Jul 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 10.3 #43195

deps: update V8 to 10.3 #43195

targos commented May 24, 2022

nodejs-github-bot commented May 24, 2022

nodejs-github-bot commented May 24, 2022 •

edited by targos

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

richardlau commented May 24, 2022

miladfarca commented May 24, 2022 •

edited

richardlau commented May 24, 2022

miladfarca commented May 24, 2022

miladfarca commented May 26, 2022

nodejs-github-bot commented May 27, 2022 •

edited by targos

targos commented Jul 12, 2022

deps: update V8 to 10.3 #43195

deps: update V8 to 10.3 #43195

Conversation

targos commented May 24, 2022

nodejs-github-bot commented May 24, 2022

nodejs-github-bot commented May 24, 2022 • edited by targos

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

targos commented May 24, 2022

richardlau commented May 24, 2022

miladfarca commented May 24, 2022 • edited

richardlau commented May 24, 2022

miladfarca commented May 24, 2022

miladfarca commented May 26, 2022

nodejs-github-bot commented May 27, 2022 • edited by targos

targos commented Jul 12, 2022

nodejs-github-bot commented May 24, 2022 •

edited by targos

miladfarca commented May 24, 2022 •

edited

nodejs-github-bot commented May 27, 2022 •

edited by targos